redis_set_cmd when iterating over the arguments array improperly checked key value (when handling the non-string key case) instead of the value

Sean-Der · Sean-Der · commit 9ff8f49a90d5 · 2015-09-07T18:16:58.000Z
diff --git a/redis_commands.c b/redis_commands.c
@@ -1250,7 +1250,7 @@ int redis_set_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
 
                 /* Expiry can't be set < 1 */
                 if (expire < 1) return FAILURE;
-            } else if (Z_TYPE_P(v) == IS_STRING && k != NULL && IS_EX_PX_ARG(k->val)) {
+            } else if (Z_TYPE_P(v) == IS_STRING && IS_NX_XX_ARG(Z_STRVAL_P(v))) {
                 set_type = Z_STRVAL_P(v);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -1250,7 +1250,7 @@ int redis_set_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,`
`1250`	`1250`
`1251`	`1251`	`/* Expiry can't be set < 1 */`
`1252`	`1252`	`if (expire < 1) return FAILURE;`
`1253`		`- } else if (Z_TYPE_P(v) == IS_STRING && k != NULL && IS_EX_PX_ARG(k->val)) {`
	`1253`	`+ } else if (Z_TYPE_P(v) == IS_STRING && IS_NX_XX_ARG(Z_STRVAL_P(v))) {`
`1254`	`1254`	`set_type = Z_STRVAL_P(v);`
`1255`	`1255`	`}`
`1256`	`1256`	`}`