diff --git a/.github/dependabot.yml b/.github/dependabot.yml index fd04e8fe..93365d5f 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -9,3 +9,6 @@ updates: directory: '/' # Location of package manifests schedule: interval: 'daily' + ignore: + - dependency-name: '*' + update-types: ['version-update:semver-patch'] diff --git a/README.md b/README.md index e4c6beaa..582d2e58 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@

-# JavaScript Cookie [![Build Status](https://travis-ci.com/js-cookie/js-cookie.svg?branch=master)](https://travis-ci.com/js-cookie/js-cookie) [![BrowserStack Status](https://www.browserstack.com/automate/badge.svg?badge_key=b3VDaHAxVDg0NDdCRmtUOWg0SlQzK2NsRVhWTjlDQS9qdGJoak1GMzJiVT0tLVhwZHNvdGRoY284YVRrRnI3eU1JTnc9PQ==--5e88ffb3ca116001d7ef2cfb97a4128ac31174c2)](https://www.browserstack.com/automate/public-build/b3VDaHAxVDg0NDdCRmtUOWg0SlQzK2NsRVhWTjlDQS9qdGJoak1GMzJiVT0tLVhwZHNvdGRoY284YVRrRnI3eU1JTnc9PQ==--5e88ffb3ca116001d7ef2cfb97a4128ac31174c2) [![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com) [![Code Climate](https://codeclimate.com/github/js-cookie/js-cookie.svg)](https://codeclimate.com/github/js-cookie/js-cookie) [![npm](https://img.shields.io/github/package-json/v/js-cookie/js-cookie)](https://www.npmjs.com/package/js-cookie) [![size](https://img.shields.io/bundlephobia/minzip/js-cookie/rc)](https://www.npmjs.com/package/js-cookie) [![jsDelivr Hits](https://data.jsdelivr.com/v1/package/npm/js-cookie/badge?style=rounded)](https://www.jsdelivr.com/package/npm/js-cookie) +# JavaScript Cookie [![Build Status](https://travis-ci.com/js-cookie/js-cookie.svg?branch=master)](https://travis-ci.com/js-cookie/js-cookie) [![BrowserStack Status](https://www.browserstack.com/automate/badge.svg?badge_key=b3VDaHAxVDg0NDdCRmtUOWg0SlQzK2NsRVhWTjlDQS9qdGJoak1GMzJiVT0tLVhwZHNvdGRoY284YVRrRnI3eU1JTnc9PQ==--5e88ffb3ca116001d7ef2cfb97a4128ac31174c2)](https://www.browserstack.com/automate/public-build/b3VDaHAxVDg0NDdCRmtUOWg0SlQzK2NsRVhWTjlDQS9qdGJoak1GMzJiVT0tLVhwZHNvdGRoY284YVRrRnI3eU1JTnc9PQ==--5e88ffb3ca116001d7ef2cfb97a4128ac31174c2) [![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com) [![Code Climate](https://codeclimate.com/github/js-cookie/js-cookie.svg)](https://codeclimate.com/github/js-cookie/js-cookie) [![npm](https://img.shields.io/github/package-json/v/js-cookie/js-cookie)](https://www.npmjs.com/package/js-cookie) [![size](https://img.shields.io/bundlephobia/minzip/js-cookie/3)](https://www.npmjs.com/package/js-cookie) [![jsDelivr Hits](https://data.jsdelivr.com/v1/package/npm/js-cookie/badge?style=rounded)](https://www.jsdelivr.com/package/npm/js-cookie) A simple, lightweight JavaScript API for handling cookies diff --git a/browserstack.json b/browserstack.json index 4797aa97..9c6345a5 100644 --- a/browserstack.json +++ b/browserstack.json @@ -29,14 +29,6 @@ "os_version": "13", "browserstack.local": "false", "browserstack.appium_version": "1.14.0" - }, - { - "device": "iPhone 8 Plus", - "real_mobile": "true", - "os": "ios", - "os_version": "12", - "browserstack.local": "false", - "browserstack.appium_version": "1.14.0" } ] } diff --git a/examples/es-module/package.json b/examples/es-module/package.json index 05337526..c9f8e3a5 100644 --- a/examples/es-module/package.json +++ b/examples/es-module/package.json @@ -13,6 +13,6 @@ "license": "ISC", "devDependencies": {}, "dependencies": { - "js-cookie": "^3.0.0-rc.0" + "js-cookie": "^3.0.0" } } diff --git a/examples/webpack/package.json b/examples/webpack/package.json index a3a148dc..564f15a5 100644 --- a/examples/webpack/package.json +++ b/examples/webpack/package.json @@ -17,6 +17,6 @@ "webpack-cli": "^3.3.9" }, "dependencies": { - "js-cookie": "^3.0.0-rc.0" + "js-cookie": "^3.0.0" } } diff --git a/package.json b/package.json index c6b09ce8..fe07031b 100644 --- a/package.json +++ b/package.json @@ -1,14 +1,17 @@ { "name": "js-cookie", - "version": "3.0.0", + "version": "3.0.1", "description": "A simple, lightweight JavaScript API for handling cookies", "browser": "dist/js.cookie.js", "module": "dist/js.cookie.mjs", "unpkg": "dist/js.cookie.min.js", "jsdelivr": "dist/js.cookie.min.js", "exports": { - "import": "./dist/js.cookie.mjs", - "require": "./dist/js.cookie.js" + ".": { + "import": "./dist/js.cookie.mjs", + "require": "./dist/js.cookie.js" + }, + "./package.json": "./package.json" }, "directories": { "test": "test" diff --git a/src/api.mjs b/src/api.mjs index acc92ae1..1f4cb5c9 100644 --- a/src/api.mjs +++ b/src/api.mjs @@ -21,8 +21,6 @@ function init (converter, defaultAttributes) { .replace(/%(2[346B]|5E|60|7C)/g, decodeURIComponent) .replace(/[()]/g, escape) - value = converter.write(value, key) - var stringifiedAttributes = '' for (var attributeName in attributes) { if (!attributes[attributeName]) { @@ -45,7 +43,8 @@ function init (converter, defaultAttributes) { stringifiedAttributes += '=' + attributes[attributeName].split(';')[0] } - return (document.cookie = key + '=' + value + stringifiedAttributes) + return (document.cookie = + key + '=' + converter.write(value, key) + stringifiedAttributes) } function get (key) { @@ -61,12 +60,8 @@ function init (converter, defaultAttributes) { var parts = cookies[i].split('=') var value = parts.slice(1).join('=') - if (value[0] === '"') { - value = value.slice(1, -1) - } - try { - var foundKey = defaultConverter.read(parts[0]) + var foundKey = decodeURIComponent(parts[0]) jar[foundKey] = converter.read(value, foundKey) if (key === foundKey) { diff --git a/src/converter.mjs b/src/converter.mjs index afb99ea7..7cd10cf2 100644 --- a/src/converter.mjs +++ b/src/converter.mjs @@ -1,6 +1,9 @@ /* eslint-disable no-var */ export default { read: function (value) { + if (value[0] === '"') { + value = value.slice(1, -1) + } return value.replace(/(%[\dA-F]{2})+/gi, decodeURIComponent) }, write: function (value) {