No need for low/high in MultiBinary space

jscriptcoder · jscriptcoder · commit 5fdcb46fde38 · 2020-10-16T09:59:58.000+02:00
diff --git a/README.md b/README.md
@@ -149,9 +149,7 @@ A client can communicate with Gymie via JSON, with the following format:
  {
    "name":  "MultiBinary",
    "n":     5,
-   "shape": [5],
-   "low":   [0],
-   "high":  [1]
+   "shape": [5]
  }
  
  // TODO MultiDiscrete
@@ -173,8 +171,8 @@ A client can communicate with Gymie via JSON, with the following format:
  {
    "name":  "Box",
    "shape": [2],
-   "low":   [-1, -1, -1],
-   "high":  [1, 1, 1]
+   "low":   [-1, -1],
+   "high":  [1, 1]
  }
  ```
  - <a name="action_sample">`action_sample`</a>: Generates a random action.
diff --git a/gymie/api.py b/gymie/api.py
@@ -199,8 +199,6 @@ def space_info(space):
     elif name == 'MultiBinary':
         info['n'] = space.n
         info['shape'] = space.shape
-        info['low'] = [0]
-        info['high'] = [1]
     elif name == 'MultiDiscrete':
         pass
 
diff --git a/tests/test_gymie_retro.py b/tests/test_gymie_retro.py
@@ -121,8 +121,6 @@ def test_action_space(self):
         self.assertEqual(info['name'], 'MultiBinary')
         self.assertEqual(info['n'], env.action_space.n)
         self.assertEqual(info['shape'], [env.action_space.n])
-        self.assertEqual(info['low'], [0])
-        self.assertEqual(info['high'], [1])
 
     def test_action_sample(self):
         instance_id = self.make_env('Airstriker-Genesis')

Original file line number	Diff line number	Diff line change
`@@ -149,9 +149,7 @@ A client can communicate with Gymie via JSON, with the following format:`
`149`	`149`	`{`
`150`	`150`	`"name": "MultiBinary",`
`151`	`151`	`"n": 5,`
`152`		`- "shape": [5],`
`153`		`- "low": [0],`
`154`		`- "high": [1]`
	`152`	`+ "shape": [5]`
`155`	`153`	`}`
`156`	`154`
`157`	`155`	`// TODO MultiDiscrete`
`@@ -173,8 +171,8 @@ A client can communicate with Gymie via JSON, with the following format:`
`173`	`171`	`{`
`174`	`172`	`"name": "Box",`
`175`	`173`	`"shape": [2],`
`176`		`- "low": [-1, -1, -1],`
`177`		`- "high": [1, 1, 1]`
	`174`	`+ "low": [-1, -1],`
	`175`	`+ "high": [1, 1]`
`178`	`176`	`}`
`179`	`177`	```
`180`	`178`	- <a name="action_sample">`action_sample`</a>: Generates a random action.