From a39e0ec4ce9a8806692d986a7ed0cd565ec7498a Mon Sep 17 00:00:00 2001 From: Domenic Denicola Date: Sat, 27 May 2023 19:45:30 +0900 Subject: [PATCH 01/12] Disable another newly-flaky XHR test --- test/web-platform-tests/to-run.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/web-platform-tests/to-run.yaml b/test/web-platform-tests/to-run.yaml index 54d39087f..957289ab9 100644 --- a/test/web-platform-tests/to-run.yaml +++ b/test/web-platform-tests/to-run.yaml @@ -1460,8 +1460,8 @@ cors-expose-star.sub.any.html: [fail, Unknown] data-uri.htm: [fail, Unknown] event-error-order.sub.html: [fail, Unknown] event-timeout-order.any.html: [fail, Unknown] -event-upload-progress-crossorigin.any.html: [flaky, Seems to have gotten worse with Node v20 but doesn't always fail] -event-upload-progress.any.html: [fail, Unknown] +event-upload-progress-crossorigin.any.html: [flaky, Used to pass before Node v20 but now sometimes gives "ERR_SOCKET_CLOSED_BEFORE_CONNECTION"] +event-upload-progress.any.html: [flaky, Used to *fail* before Node v20 but now sometimes gives "ERR_SOCKET_CLOSED_BEFORE_CONNECTION"] formdata.html: "Newly created FormData contains entries added to \"formData\" IDL attribute of FormDataEvent.": [fail, FormDataEvent not implemented] "|new FormData()| in formdata event handler should throw": [fail, FormDataEvent not implemented] From 032df9ceb70166f0e5e799577fc5e603b84ec3bd Mon Sep 17 00:00:00 2001 From: Domenic Denicola Date: Sun, 26 Nov 2023 20:38:04 +0900 Subject: [PATCH 02/12] Reflect the move from master to main --- .github/workflows/jsdom-ci.yml | 6 ++---- Changelog.md | 4 ++-- Contributing.md | 4 ++-- README.md | 2 +- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/.github/workflows/jsdom-ci.yml b/.github/workflows/jsdom-ci.yml index b6b43f78b..7e183e8cf 100644 --- a/.github/workflows/jsdom-ci.yml +++ b/.github/workflows/jsdom-ci.yml @@ -2,11 +2,9 @@ name: JSDOM-CI on: push: - branches: - - master + branches: [main] pull_request: - branches: - - master + branches: [main] permissions: contents: read diff --git a/Changelog.md b/Changelog.md index ed697f1c9..b0670896e 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1131,7 +1131,7 @@ This major release has as its headlining feature a completely re-written `XMLHtt This major release is focused on massive improvements in speed, URL parsing, and error handling. The potential breaking changes are highlighted in bold below; the largest ones are around the `jsdom.env` error-handling paradigm. -This release also welcomes [long-time contributer](https://github.com/jsdom/jsdom/commits/master?author=Joris-van-der-Wel) [@Joris-van-der-Wel](https://github.com/Joris-van-der-Wel/) to the core team. You may recognize him from earlier changelogs. We're very happy to have his help in making jsdom awesome! +This release also welcomes [long-time contributer](https://github.com/jsdom/jsdom/commits/main?author=Joris-van-der-Wel) [@Joris-van-der-Wel](https://github.com/Joris-van-der-Wel/) to the core team. You may recognize him from earlier changelogs. We're very happy to have his help in making jsdom awesome! * **io.js 2.0 onward is now required**, as we have begun using ES2015 features only present there. * Improved performance dramatically, by ~10000x in some cases, due to the following changes: @@ -1182,7 +1182,7 @@ Finally, if you're a loyal jsdom fan whose made it this far into the changelog, * Fixed clicking on submit `