binary number in 64 bits

arodriguez33 · arodriguez33 · commit 6312a1ee872d · 2019-01-29T19:09:17.000-03:00
diff --git a/src/main/java/com/conversions/BinaryToHexadecimal.java b/src/main/java/com/conversions/BinaryToHexadecimal.java
@@ -1,5 +1,6 @@
 package src.main.java.com.conversions;
 
+import java.math.BigInteger;
 import java.util.HashMap;
 
 public class BinaryToHexadecimal {
@@ -12,7 +13,7 @@ public class BinaryToHexadecimal {
      * @return The hexadecimal number
      */
 
-    public String binToHex(long binary) {
+    public String binToHex(BigInteger binary) {
         //hm to store hexadecimal codes for binary numbers within the range: 0000 to 1111 i.e. for decimal numbers 0 to 15
         HashMap<Integer,String> hmHexadecimal = new HashMap<>();
 
@@ -25,14 +26,15 @@ public String binToHex(long binary) {
         for(i=10 ; i<16 ; i++)
             hmHexadecimal.put(i,String.valueOf((char)('A'+i-10)));
 
-        long currentbit;
-        while(binary != 0) {
+        int currentbit;
+        BigInteger tenValue = new BigInteger("10");
+        while(binary.compareTo(BigInteger.ZERO) != 0) {
             int code4 = 0;	//to store decimal equivalent of number formed by 4 decimal digits
             for(i=0 ; i<4 ; i++)
             {
-                currentbit = binary % 10;
-                binary = binary / 10;
-                code4 += currentbit * Math.pow(2, i);
+                currentbit = binary.mod(tenValue).intValueExact();
+                binary = binary.divide(tenValue);
+                code4 += currentbit*Math.pow(2, i);
             }
             hex= hmHexadecimal.get(code4) + hex;
         }
diff --git a/src/test/java/com/conversions/BinaryToHexadecimalTest.java b/src/test/java/com/conversions/BinaryToHexadecimalTest.java
@@ -9,7 +9,8 @@ public class BinaryToHexadecimalTest {
     @Test
     public void testBinaryToHexadecimal(){
         BinaryToHexadecimal binaryToHexadecimal = new BinaryToHexadecimal();
-        Assert.assertEquals("Incorrect Conversion", "2A", binaryToHexadecimal.binToHex(101010));
-        Assert.assertEquals("Incorrect Conversion", "24", binaryToHexadecimal.binToHex(100100));
+        Assert.assertEquals("Incorrect Conversion", "2A", binaryToHexadecimal.binToHex(new BigInteger("101010")));
+        Assert.assertEquals("Incorrect Conversion", "24", binaryToHexadecimal.binToHex(new BigInteger("100100")));
+        Assert.assertEquals("Incorrect Conversion", "AAAAAAAAAAAAAAAAAA1", binaryToHexadecimal.binToHex(new BigInteger("1010101010101010101010101010101010101010101010101010101010101010101010100001")));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,8 @@ public class BinaryToHexadecimalTest {`
`9`	`9`	`@Test`
`10`	`10`	`public void testBinaryToHexadecimal(){`
`11`	`11`	`BinaryToHexadecimal binaryToHexadecimal = new BinaryToHexadecimal();`
`12`		`- Assert.assertEquals("Incorrect Conversion", "2A", binaryToHexadecimal.binToHex(101010));`
`13`		`- Assert.assertEquals("Incorrect Conversion", "24", binaryToHexadecimal.binToHex(100100));`
	`12`	`+ Assert.assertEquals("Incorrect Conversion", "2A", binaryToHexadecimal.binToHex(new BigInteger("101010")));`
	`13`	`+ Assert.assertEquals("Incorrect Conversion", "24", binaryToHexadecimal.binToHex(new BigInteger("100100")));`
	`14`	`+ Assert.assertEquals("Incorrect Conversion", "AAAAAAAAAAAAAAAAAA1", binaryToHexadecimal.binToHex(new BigInteger("1010101010101010101010101010101010101010101010101010101010101010101010100001")));`
`14`	`15`	`}`
`15`	`16`	`}`