Skip to content

Commit 202ce73

Browse files
committed
Rename build to test in CI. Fix failing tests after the language_id to language change.
1 parent 6993ff6 commit 202ce73

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ permissions:
88
contents: read
99

1010
jobs:
11-
build:
11+
test:
1212
runs-on: ubuntu-latest
1313

1414
steps:
@@ -28,5 +28,9 @@ jobs:
2828
JUDGE0_ATD_API_KEY: ${{ secrets.JUDGE0_ATD_API_KEY }}
2929
JUDGE0_RAPID_API_KEY: ${{ secrets.JUDGE0_RAPID_API_KEY }}
3030
JUDGE0_SULU_API_KEY: ${{ secrets.JUDGE0_SULU_API_KEY }}
31+
JUDGE0_TEST_API_KEY: ${{ secrets.JUDGE0_TEST_API_KEY }}
32+
JUDGE0_TEST_API_KEY_HEADER: ${{ secrets.JUDGE0_TEST_API_KEY_HEADER }}
33+
JUDGE0_TEST_CE_ENDPOINT: ${{ secrets.JUDGE0_TEST_CE_ENDPOINT }}
34+
JUDGE0_TEST_EXTRA_CE_ENDPOINT: ${{ secrets.JUDGE0_TEST_EXTRA_CE_ENDPOINT }}
3135
run: |
3236
pipenv run pytest -vv

src/judge0/clients.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,7 @@ def create_submissions(self, submissions: list[Submission]) -> list[Submission]:
147147
f"{submission.language}!"
148148
)
149149

150-
submissions_body = [submission.to_dict() for submission in submissions]
151-
# We have to resolve language_id because language_id can be Language
152-
# enumeration.
153-
for submission_body in submissions_body:
154-
submission_body["language_id"] = self.resolve_language_id(
155-
submission_body["language_id"]
156-
)
150+
submissions_body = [submission.to_dict(self) for submission in submissions]
157151

158152
resp = requests.post(
159153
f"{self.endpoint}/submissions/batch",

tests/test_api.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,12 @@ def test_resolve_client_empty_submissions_argument(submissions):
5757
def test_resolve_client_no_common_client_for_submissions():
5858
cpp_submission = Submission(
5959
source_code="", # source code is not important in this test
60-
language_id=LanguageAlias.CPP_GCC,
60+
language=LanguageAlias.CPP_GCC,
6161
)
6262

6363
py_submission = Submission(
6464
source_code="", # source code is not important in this test
65-
language_id=LanguageAlias.PYTHON_FOR_ML,
65+
language=LanguageAlias.PYTHON_FOR_ML,
6666
)
6767

6868
submissions = [cpp_submission, py_submission]
@@ -74,12 +74,12 @@ def test_resolve_client_no_common_client_for_submissions():
7474
def test_resolve_client_common_ce_client():
7575
cpp_submission = Submission(
7676
source_code="", # source code is not important in this test
77-
language_id=LanguageAlias.CPP_GCC,
77+
language=LanguageAlias.CPP_GCC,
7878
)
7979

8080
py_submission = Submission(
8181
source_code="", # source code is not important in this test
82-
language_id=LanguageAlias.PYTHON,
82+
language=LanguageAlias.PYTHON,
8383
)
8484

8585
submissions = [cpp_submission, py_submission]
@@ -90,12 +90,12 @@ def test_resolve_client_common_ce_client():
9090
def test_resolve_client_common_extra_ce_client():
9191
cpp_submission = Submission(
9292
source_code="", # source code is not important in this test
93-
language_id=LanguageAlias.CPP_CLANG,
93+
language=LanguageAlias.CPP_CLANG,
9494
)
9595

9696
py_submission = Submission(
9797
source_code="", # source code is not important in this test
98-
language_id=LanguageAlias.PYTHON_FOR_ML,
98+
language=LanguageAlias.PYTHON_FOR_ML,
9999
)
100100

101101
submissions = [cpp_submission, py_submission]

0 commit comments

Comments
 (0)