Fix for infinity

martinRenou · martinRenou · commit 55d6e4294c25 · 2021-09-28T11:58:19.000+02:00
diff --git a/js/scripts/prop-types.js b/js/scripts/prop-types.js
@@ -6,8 +6,6 @@ const JS_WIDGET_SERIALIZER = '{ deserialize: serializers.unpackThreeModel }';
 function pythonify(value) {
     if (value === false) { return 'False'; }
     if (value === true) { return 'True'; }
-    if (value === Infinity) { return "float('inf')"; }
-    if (value === -Infinity) { return "-float('inf')"; }
     if (value === undefined || value === null) { return 'None'; }
     if (Array.isArray(value)) {
         return `[${
diff --git a/js/src/_base/Three.js b/js/src/_base/Three.js
@@ -487,29 +487,10 @@ var ThreeModel = widgets.WidgetModel.extend({
 
     // Float
     convertFloatModelToThree: function(v) {
-        if (typeof v === 'string' || v instanceof String) {
-            v = v.toLowerCase();
-            if (v === 'inf') {
-                return Infinity;
-            } else if (v === '-inf') {
-                return -Infinity;
-            } else if (v === 'nan') {
-                return NaN;
-            }
-        }
         return v;
     },
 
     convertFloatThreeToModel: function(v) {
-        if (isFinite(v)) { // Most common first
-            return v;
-        } else if (isNaN(v)) {
-            return 'nan';
-        } else if (v === Infinity) {
-            return 'inf';
-        } else if (v === -Infinity) {
-            return '-inf';
-        }
         return v;
     },
 
