Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kafka-python-ng/kafka-python-ng
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.3
Choose a base ref
...
head repository: kafka-python-ng/kafka-python-ng
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.0
Choose a head ref
  • 19 commits
  • 112 files changed
  • 14 contributors

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    e796019 View commit details
    Browse the repository at this point in the history
  2. Reconfigure tests to complete in a more timely manner and skip some i…

    …terations for Kafka 0.8.2 and Python 3.12 (#159)
    
    * skip failing tests for PyPy since they work locally
    
    * Reconfigure tests for PyPy and 3.12
    
    * Skip partitioner tests in test_partitioner.py if 3.12 and 0.8.2
    
    * Update test_partitioner.py
    
    * Update test_producer.py
    
    * Timeout tests after ten minutes
    
    * Set 0.8.2.2 to be experimental from hereon
    
    * Formally support PyPy 3.9
    wbarnha authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    38e159a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Test Kafka 0.8.2.2 using Python 3.10 in the meantime (#161)

    * Test Kafka 0.8.2.2 using Python 3.11 in the meantime
    
    * Override PYTHON_LATEST conditionally in python-package.yml
    
    * Update python-package.yml
    
    * add python annotation to kafka version test matrix
    
    * Update python-package.yml
    
    * try python 3.10
    wbarnha authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    e762321 View commit details
    Browse the repository at this point in the history
  2. Remove support for EOL'ed versions of Python (#160)

    * Remove support for EOL'ed versions of Python
    
    * Update setup.py
    wbarnha authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    00750aa View commit details
    Browse the repository at this point in the history
  3. Stop testing Python 3.13 in python-package.yml (#162)

    Too many MRs to review... so little time.
    wbarnha authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    5bd1323 View commit details
    Browse the repository at this point in the history
  4. Avoid 100% CPU usage while socket is closed (#156)

    After stop/start kafka service, kafka-python may use 100% CPU caused by
    busy-retry while the socket was closed. This fix the issue by unregister
    the socket if the fd is negative.
    
    Co-authored-by: Orange Kao <orange@aiven.io>
    wbarnha and orange-kao authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    cda8f81 View commit details
    Browse the repository at this point in the history
  5. Fix DescribeConfigsResponse_v1 config_source (#150)

    Co-authored-by: Ryar Nyah <ryarnyah@gmail.com>
    wbarnha and ryarnyah authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    c02df08 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Fix base class of DescribeClientQuotasResponse_v0 (#144)

    Co-authored-by: Denis Otkidach <denis.otkidach@gmail.com>
    wbarnha and ods authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    65eacfb View commit details
    Browse the repository at this point in the history
  2. Update license_file to license_files (#131)

    The former has been deprecated since setuptools 56
    
    Co-authored-by: micwoj92 <45581170+micwoj92@users.noreply.github.com>
    wbarnha and micwoj92 authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    e0ebe5d View commit details
    Browse the repository at this point in the history
  3. Update some RST documentation syntax (#130)

    * docs: Update syntax in README.rst
    
    * docs: Update code block syntax in docs/index.rst
    
    ---------
    
    Co-authored-by: HalfSweet <60973476+HalfSweet@users.noreply.github.com>
    wbarnha and HalfSweet authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    26bb3eb View commit details
    Browse the repository at this point in the history
  4. Fix crc32c's __main__ for Python 3 (#142)

    * Fix crc32c's __main__ for Python 3
    
    * Remove TODO from _crc32c.py
    
    ---------
    
    Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com>
    wbarnha and Jongy authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    88763da View commit details
    Browse the repository at this point in the history
  5. Strip trailing dot off hostname. (#133)

    Co-authored-by: Dave Voutila <voutilad@gmail.com>
    wbarnha and voutilad authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    b1a4c53 View commit details
    Browse the repository at this point in the history
  6. Handle OSError to properly recycle SSL connection, fix infinite loop (#…

    …155)
    
    * handling OSError
    
    * better error output
    
    * removed traceback logging
    
    ---------
    
    Co-authored-by: Alexander Sibiryakov <sixty-one@yandex.ru>
    wbarnha and sibiryakov authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    18eaa2d View commit details
    Browse the repository at this point in the history
  7. client_async: Allow throwing an exception upon socket error during (#134

    )
    
    wakeup
    
    When wakeup() is called, we sometime notice that we get
    an endless prints:
    "Unable to send to wakeup socket!".
    
    Those prints are spamming the logs.
    This commit aims to address it by allowing restating the
    application via an intentional exception raise.
    This behavior is configurable and its default is backward compatible.
    
    Signed-off-by: shimon-armis <shimon.turjeman@armis.com>
    Co-authored-by: shimon-armis <shimon.turjeman@armis.com>
    wbarnha and shimonturjeman authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    54cbd63 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Log connection errors at ERROR level (#139)

    Co-authored-by: drewdogg <drewdogg@users.noreply.github.com>
    wbarnha and drewdogg authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    eb6fd9b View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Support custom SASL mechanisms including AWS MSK (#170)

    * Support custom SASL mechanisms
    
    There is some interest in supporting various SASL mechanisms not
    currently included in the library:
    
    * dpkp#2110 (DMS)
    * dpkp#2204 (SSPI)
    * dpkp#2232 (AWS_MSK_IAM)
    
    Adding these mechanisms in the core library may be undesirable due to:
    
    * Increased maintenance burden.
    * Unavailable testing environments.
    * Vendor specificity.
    
    This commit provides a quick prototype for a pluggable SASL system.
    
    ---
    
    **Example**
    
    To define a custom SASL mechanism a module must implement two methods:
    
    ```py
    
    def validate_config(conn):
        # Check configuration values, available libraries, etc.
        assert conn.config['vendor_specific_setting'] is not None, (
            'vendor_specific_setting required when sasl_mechanism=MY_SASL'
        )
    
    def try_authenticate(conn, future):
        # Do authentication routine and return resolved Future with failed
        # or succeeded state.
    ```
    
    And then the custom mechanism should be registered before initializing
    a KafkaAdminClient, KafkaConsumer, or KafkaProducer:
    
    ```py
    
    import kafka.sasl
    from kafka import KafkaProducer
    
    import my_sasl
    
    kafka.sasl.register_mechanism('MY_SASL', my_sasl)
    
    producer = KafkaProducer(sasl_mechanism='MY_SASL')
    ```
    
    ---
    
    **Notes**
    
    **ABCs**
    
    This prototype does not implement an ABC for custom SASL mechanisms.
    Using an ABC would reduce a few of the explicit assertions involved with
    registering a mechanism and is a viable option. Due to differing feature
    sets between py2/py3 this option was not explored, but shouldn't be
    difficult.
    
    **Private Methods**
    
    This prototype relies on some methods that are currently marked as
    **private** in `BrokerConnection`.
    
    * `._can_send_recv`
    * `._lock`
    * `._recv_bytes_blocking`
    * `._send_bytes_blocking`
    
    A pluggable system would require stable interfaces for these actions.
    
    **Alternative Approach**
    
    If the module-scoped dict modification in `register_mechanism` feels too
    clunky maybe the addtional mechanisms can be specified via an argument
    when initializing one of the `Kafka*` classes?
    
    * Add test_msk.py by @mattoberle
    
    * add msk to __init__ and check for extension in conn.py
    
    * rename try_authenticate in msk.py
    
    * fix imports
    
    * fix imports
    
    * add botocore to requirements-dev.txt
    
    * add boto3 to requirements-dev.txt
    
    * add awscli to requirements-dev.txt
    
    * add awscli to workflow since it takes too long to install normally
    
    * just install botocore i guess
    
    * just install boto3 i guess
    
    * force reinstall awscli
    
    * try something weird
    
    * ok now the dang tests should work and if they don't i'll cry
    
    * skip the msk test for now...
    
    * Revert "skip the msk test for now..."
    
    This reverts commit 1c29667.
    
    * skip the msk test for now...
    
    * nvm just needed to update tox lol
    
    * Update kafka/sasl/gssapi.py
    
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    
    * Update kafka/sasl/oauthbearer.py
    
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    
    * Update kafka/sasl/plain.py
    
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    
    * Update kafka/sasl/scram.py
    
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    
    * Update kafka/sasl/msk.py
    
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Matt Oberle <mattoberle@users.noreply.github.com>
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    3 people authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6ad79a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    deeccfa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fcca556 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Remove all vendoring (#169)

    Now that the codebase has been modernised by using pyupgrade, we can
    also remove all backported vendor modules, and all uses of them.
    s-t-e-v-e-n-k authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a856dc4 View commit details
    Browse the repository at this point in the history
Loading