Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kafka-python-ng/kafka-python-ng
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.0
Choose a base ref
...
head repository: kafka-python-ng/kafka-python-ng
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 18 commits
  • 37 files changed
  • 11 contributors

Commits on Mar 8, 2024

  1. Update README.rst

    wbarnha authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a6d0579 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Support Describe log dirs (#145)

    I implemented API KEY 35 from the official Apache Kafka documentation. This functionality is requested in issue # 2163 and this is an implementation proposal.
    
    Co-authored-by: chopatate <florian.courouge@outlook.fr>
    wbarnha and Courouge authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    2f2ccb1 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Update conftest.py to use request.node.originalname instead for legal…

    … topic naming (#172)
    
    * Update conftest.py to use request.node.originalname instead for legal topic naming
    
    Otherwise parametrization doesn't work.
    
    * Update test/conftest.py
    
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
    wbarnha and code-review-doctor[bot] authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0259502 View commit details
    Browse the repository at this point in the history
  2. KIP-345 Static membership implementation (#137)

    * KIP-345 Add static consumer membership support
    
    * KIP-345 Add examples to docs
    
    * KIP-345 Add leave_group_on_close flag
    
    https://issues.apache.org/jira/browse/KAFKA-6995
    
    * KIP-345 Add tests for static membership
    
    * KIP-345 Update docs for leave_group_on_close option
    
    * Update changelog.rst
    
    * remove six from base.py
    
    * Update base.py
    
    * Update base.py
    
    * Update base.py
    
    * Update changelog.rst
    
    * Update README.rst
    
    ---------
    
    Co-authored-by: Denis Kazakov <d.kazakov@mcplat.ru>
    Co-authored-by: Denis Kazakov <denis@kazakov.ru.net>
    3 people authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3c124b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Use monkeytype to create some semblance of typing (#173)

    * Add typing
    
    * define types as Struct for simplicity's sake
    wbarnha authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    56065da View commit details
    Browse the repository at this point in the history
  2. Add zstd support on legacy record and ensure no variable is referred …

    …before definition (#138)
    
    * fix if statement logic and add zstd check
    
    * fix if statement logic and add zstd uncompress
    
    * fix imports
    
    * avoid variable be used before definition
    
    * Remove unused import from legacy_records.py
    
    ---------
    
    Co-authored-by: Alexandre Souza <alexandre.souza@axonius.com>
    wbarnha and ax-ale authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cbf317b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    af1a5f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aba153f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Add connection_timeout_ms and reset the timeout counter more often (#132

    )
    
    * Add connection_timeout_ms and reset the timeout counter more often
    
    * Refactor last_attempt -> last_activity
    This semantically reflects the new usage of the variable better
    
    * Make tests work again
    
    * Add unit tests of new BrokerConnection functionality
    The test mocks parts of BrokerConnection in order to assert that the connection state machine allows long-lasting connections as long as the state progresses often enough
    
    * Re-introduce last_attempt to avoid breakage
    
    ---------
    
    Co-authored-by: Liam S. Crouch <spam@petterroea.com>
    wbarnha and petterroea authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6c9eb37 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    6756974 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Fix ssl connection (#178)

    * Fix ssl connection after wrap_ssl
    
    * test
    
    * refactor
    
    * remove global level
    
    * test
    
    * revert test
    
    * address comments
    dingxiong authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    611471f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Fix badge typo in README.rst

    wbarnha authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    deebd8f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    448017e View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Patch pylint warnings so tests pass again (#184)

    * stop pylint complaint for uncovered conditional flow
    
    * add todo to revisit
    
    * formatting makes me happy :)
    
    * Fix errors raised by new version of Pylint so tests pass again
    wbarnha authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5e461a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Update README.rst to close #179

    wbarnha authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    401896b View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Avoid busy retry (#192)

    Test test/test_consumer_group.py::test_group and
    test/test_admin_integration.py::test_describe_consumer_group_exists
    busy-retry and this might have caused Java not having enough CPU time on
    GitHub runner, and result in test failure.
    orange-kao authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    31a6b92 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. fix scram username character escape (#196)

    According to [rfc5802](https://datatracker.ietf.org/doc/html/rfc5802), username should escape special characters before sending to the server.
    > The characters ',' or '=' in usernames are sent as '=2C' and
             '=3D' respectively.  If the server receives a username that
             contains '=' not followed by either '2C' or '3D', then the
             server MUST fail the authentication.
    debuggings authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9bee9fc View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Improve test/test_consumer_integration.py in GitHub runner (#194)

    test/test_consumer_integration.py::test_kafka_consumer__blocking failed
    in
    https://github.com/wbarnha/kafka-python-ng/actions/runs/10361086008/job/28680735389?pr=186
    because it took 592ms to finish. Output from the GitHub runner attached
    
    This commit increase TIMEOUT_MS so it is less likely to fail on GitHub
    runner.
    
              # Ask for 5 messages, 10 in queue. Get 5 back, no blocking
              messages = []
              with Timer() as t:
                  for i in range(5):
                      msg = next(consumer)
                      messages.append(msg)
              assert_message_count(messages, 5)
      >       assert t.interval < (TIMEOUT_MS / 1000.0)
      E       assert 0.5929090976715088 < (500 / 1000.0)
      E        +  where 0.5929090976715088 = <test.testutil.Timer object at 0x7f6c4b50e960>.interval
    
    Co-authored-by: William Barnhart <williambbarnhart@gmail.com>
    orange-kao and wbarnha authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6104623 View commit details
    Browse the repository at this point in the history
Loading