Skip to content

Request timeout (%s) must be larger than session timeout (%s) [1.4.5] #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wbarnha opened this issue Mar 8, 2024 · 0 comments
Open

Comments

@wbarnha
Copy link
Collaborator

wbarnha commented Mar 8, 2024

In 1.4.5, session_timeout acts as a lower bound for request_timeout.

This seems excessively strict. If we use a short timeout like 2s, the heartbeat thread could simply retry, there seems to be some logic already in for that.

In the current implementation, I found these blockers:

If we clear these, I think we should allow short request_timeouts.

My goal is to allow better recovery with unstable connections (which do occassionally occur in our environment)

@dpkp what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant