From d7db2a1fdf3c8366c85c4baa39df849b3d4deb21 Mon Sep 17 00:00:00 2001 From: William Barnhart Date: Tue, 19 Mar 2024 20:51:52 -0400 Subject: [PATCH 1/2] Update conftest.py to use request.node.originalname instead for legal topic naming Otherwise parametrization doesn't work. --- test/conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/conftest.py b/test/conftest.py index 3fa0262fd..2956d9a4d 100644 --- a/test/conftest.py +++ b/test/conftest.py @@ -119,7 +119,7 @@ def factory(**kafka_admin_client_params): @pytest.fixture def topic(kafka_broker, request): """Return a topic fixture""" - topic_name = '%s_%s' % (request.node.name, random_string(10)) + topic_name = '%s_%s' % (request.node.originalname, random_string(10)) kafka_broker.create_topics([topic_name]) return topic_name From b0ff9f3356b4cfbe7ee787e2dcc9acb5abb7ffea Mon Sep 17 00:00:00 2001 From: William Barnhart Date: Tue, 19 Mar 2024 20:52:29 -0400 Subject: [PATCH 2/2] Update test/conftest.py Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> --- test/conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/conftest.py b/test/conftest.py index 2956d9a4d..824c0fa76 100644 --- a/test/conftest.py +++ b/test/conftest.py @@ -119,7 +119,7 @@ def factory(**kafka_admin_client_params): @pytest.fixture def topic(kafka_broker, request): """Return a topic fixture""" - topic_name = '%s_%s' % (request.node.originalname, random_string(10)) + topic_name = f'{request.node.originalname}_{random_string(10)}' kafka_broker.create_topics([topic_name]) return topic_name