[Emacs 30.1] Refactor turning off global-completion-preview-mode

jeffbowman · jeffbowman · commit 50b16de4cfb0 · 2025-03-07T14:28:54.000-06:00
Move turning off global completion preview mode to the configuration
for Corfu instead of Vertico.
diff --git a/modules/crafted-completion-config.el b/modules/crafted-completion-config.el
@@ -30,11 +30,7 @@
     (fido-mode -1)
     (fido-vertical-mode -1)
     (icomplete-mode -1)
-    (icomplete-vertical-mode -1)
-    (when (version< "30" emacs-version)
-      ;; this mode is only available in Emacs version 30.1 and
-      ;; greater.
-      (global-completion-preview-mode -1))))
+    (icomplete-vertical-mode -1)))
 
 
 ;;; Marginalia
@@ -83,6 +79,11 @@
 ;;; Corfu
 (when (require 'corfu nil :noerror)
 
+  (when (version< "30" emacs-version)
+    ;; this mode is only available in Emacs version 30.1 and
+    ;; greater.
+    (global-completion-preview-mode -1))
+  
   (unless (display-graphic-p)
     (when (require 'corfu-terminal nil :noerror)
       (corfu-terminal-mode +1)))
