Fix wrong handle lifecycle

nulltoken · nulltoken · commit 9e82f3043e01 · 2014-06-02T19:36:31.000+02:00
git_branch_delete() only frees the handle upon success.
diff --git a/LibGit2Sharp/Core/Proxy.cs b/LibGit2Sharp/Core/Proxy.cs
@@ -161,8 +161,8 @@ public static void git_branch_delete(ReferenceSafeHandle reference)
             using (ThreadAffinity())
             {
                 int res = NativeMethods.git_branch_delete(reference);
-                reference.SetHandleAsInvalid();
                 Ensure.ZeroResult(res);
+                reference.SetHandleAsInvalid();
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -161,8 +161,8 @@ public static void git_branch_delete(ReferenceSafeHandle reference)`
`161`	`161`	`using (ThreadAffinity())`
`162`	`162`	`{`
`163`	`163`	`int res = NativeMethods.git_branch_delete(reference);`
`164`		`- reference.SetHandleAsInvalid();`
`165`	`164`	`Ensure.ZeroResult(res);`
	`165`	`+ reference.SetHandleAsInvalid();`
`166`	`166`	`}`
`167`	`167`	`}`
`168`	`168`