-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent GUI rendering when accessing Kedro pipeline via localhost vs device IP #2198
Comments
It isn't a CORS issue. It's because there's a function that checks if the URL is deemed to be running locally, which then changes some elements of the UI. This is the code: Lines 194 to 207 in eac8d39
If your |
Thank you for the quick response! I'm glad to hear it's not a CORS issue-those can be trickier to deal with! Is there currently a more polished way to add a custom host to this list? If not, do you think it might be worth exploring a way to make this process more flexible? For instance, allowing users to configure their own addresses or perhaps reconsidering the assumption that these UI elements are only relevant for local environments. I'd potentially be happy to help contribute if this is something worth pursuing! |
I agree this is inconsistent, we could do several things here. Option 1: Cover the standard private IP address ranges defined in RFC 1918 this should cover the 192.168.X.X subnet. Option 2: We consider allowing users to define what they consider 'local' via configuration options:
@astrojuanlu @Huongg what are your thoughts? |
I'm curious, any reason why the UI looks different depending on |
Description/Context
I am currently hosting a kedro viz instance on my local machine (for example, local ip address of 192.168.0.9) on a specified port, for this example let's say port 1234.
So, if I go to
localhost:1234
I get a "complete" kedro visualization:I want to quickly share this visualization with my coworker on my network. I expose that port, and direct them to `192.168.0.9:1234'. However, when they visit, they get an "incomplete" kedro visualization that is missing the experiments tab, among other things:
Interestingly, if I direct them to the experiments page directly
192.168.0.7:1008/experiment-tracking
, the page does work and they are able to access the experiments page. So, this appears to just be a GUI problem (Cross-Origin Resource Sharing?!?).I acknowledge that there are better ways of sharing these dashboards, but give my current development needs, I want to be able to quickly share the dashboard running on my machine with coworkers on my network.
Steps to Reproduce
kedro viz run --host=0.0.0.0 --port=1008
localhost:1234
and note that the full dashboard is hosted, as expected.<your-local-ip>:1234
Expected Result
<your-local-ip>:1234
should be exactly the same as thelocalhost:1234
version.Actual Result
<your-local-ip>:1234
is missing certain functionality, for example the experiments button, when compared to thelocalhost:1234
version.Environment
Thank you in advance for your help! I've only been using kedro a few hours, so my apologies if this is basic question!
The text was updated successfully, but these errors were encountered: