Pep8 and code style improvements

inclement · inclement · commit 173ee9ec60a2 · 2019-08-03T00:09:30.000+01:00
diff --git a/tests/test_androidmodule_ctypes_finder.py b/tests/test_androidmodule_ctypes_finder.py
@@ -4,7 +4,7 @@
 try:  # Python 3+
     from unittest import mock
     from unittest.mock import MagicMock
-except:  # Python 2
+except ImportError:  # Python 2
     import mock
     from mock import MagicMock
 import os
diff --git a/tests/test_recommendations.py b/tests/test_recommendations.py
@@ -1,6 +1,6 @@
 import unittest
 from os.path import join
-from sys import version_info, version as py_version
+from sys import version as py_version
 
 from unittest import mock
 from pythonforandroid.recommendations import (
@@ -34,7 +34,6 @@
     PY2_ERROR_TEXT,
     PY_VERSION_ERROR_TEXT,
 )
-import pythonforandroid.recommendations  # for mocking constants only, other imports explicit
 
 from pythonforandroid.util import BuildInterruptingException
 
@@ -206,8 +205,8 @@ def test_check_ndk_api_warning_old_ndk(self):
         )
 
     def test_check_python_version(self):
-        """
-        With any version info lower than the minimum, we should get a
+        """With any version info lower than the minimum, we should get a
+        BuildInterruptingException with an appropriate message.
         """
         with mock.patch('sys.version_info') as fake_version_info:
 
diff --git a/tox.ini b/tox.ini
@@ -31,7 +31,7 @@ commands = flake8 pythonforandroid/ tests/ ci/
 
 [flake8]
 ignore =
-    E123, E124, E126,
+    E123, E124, E126, E127, E129
     E226,
     E402, E501,
     W503,
