Skip to content

Commit 924b18c

Browse files
committed
[testapp] Enhance gh-actions with a matrix for our testapps
1 parent 48def8e commit 924b18c

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

.github/workflows/push.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,21 @@ jobs:
4747
runs-on: ubuntu-latest
4848
strategy:
4949
matrix:
50-
build-arch: ['arm64-v8a', 'armeabi-v7a']
50+
build-arch: ['arm64-v8a', 'armeabi-v7a', 'x86_64']
51+
python-version: ['python2', 'python3']
5152
steps:
5253
- name: Checkout python-for-android
5354
uses: actions/checkout@v1
5455
- name: Pull docker image
5556
run: |
5657
make docker/pull
57-
- name: Build apk for Python 3 ${{ matrix.build-arch }}
58+
- name: Build apk ${{ matrix.python-version }} ${{ matrix.build-arch }}
5859
run: |
5960
mkdir -p apks
60-
make docker/run/make/with-artifact/testapps/python3/${{ matrix.build-arch }}
61+
make docker/run/make/with-artifact/testapps/${{ matrix.python-version }}/${{ matrix.build-arch }}
6162
- uses: actions/upload-artifact@v1
6263
with:
63-
name: bdist_test_app_unittests__${{ matrix.build-arch }}-debug-1.1.apk
64+
name: test_app_unittests__${{ matrix.python-version }}-${{ matrix.build-arch }}-debug-1.1.apk
6465
path: apks
6566

6667
rebuild_updated_recipes:

Makefile

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,18 @@ rebuild_updated_recipes: virtualenv
3535
ANDROID_SDK_HOME=$(ANDROID_SDK_HOME) ANDROID_NDK_HOME=$(ANDROID_NDK_HOME) \
3636
$(PYTHON) ci/rebuild_updated_recipes.py
3737

38-
testapps/python2/armeabi-v7a: virtualenv
39-
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
40-
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
41-
--requirements sdl2,pyjnius,kivy,python2,openssl,requests,sqlite3,setuptools,numpy
42-
43-
testapps/python3/arm64-v8a: virtualenv
38+
testapps/python2/%: virtualenv
39+
$(eval $@_APP_ARCH := $(shell basename $*))
4440
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
4541
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
46-
--arch=arm64-v8a
42+
--requirements sdl2,pyjnius,kivy,python2,openssl,requests,sqlite3,setuptools,numpy \
43+
--arch=$($@_APP_ARCH)
4744

48-
testapps/python3/armeabi-v7a: virtualenv
45+
testapps/python3/%: virtualenv
46+
$(eval $@_APP_ARCH := $(shell basename $*))
4947
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
5048
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
51-
--arch=armeabi-v7a
49+
--arch=$($@_APP_ARCH)
5250

5351
clean:
5452
find . -type d -name "__pycache__" -exec rm -r {} +

0 commit comments

Comments
 (0)