From b0e63103e9e141d2c3142366e7fc4ff6df700321 Mon Sep 17 00:00:00 2001 From: Andre Miras Date: Fri, 3 Apr 2020 19:59:46 +0200 Subject: [PATCH] Fix coveralls error on GitHub Actions Coveralls started failing suddenly in GitHub Actions Worflows. This feels like a bug on their side (at least their documentation) because the `CI` environment variable is not supposed to be set refs: https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables Disabling the `coveralls` conditional run from the `Makefile` fixes it. It wasn't needed as Travis already calls it explicitly without going through the `test` target. Error was: ``` /bin/sh: 1: .tox/py36/bin/coveralls: not found Makefile:30: recipe for target 'test' failed make: *** [test] Error 127 ``` --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index e939408a63..4b5b1f4414 100644 --- a/Makefile +++ b/Makefile @@ -28,7 +28,6 @@ virtualenv: $(VIRTUAL_ENV) # ignores test_pythonpackage.py since it runs for too long test: $(TOX) -- tests/ --ignore tests/test_pythonpackage.py - @if test -n "$$CI"; then .tox/py$(PYTHON_MAJOR_MINOR)/bin/coveralls; fi; \ rebuild_updated_recipes: virtualenv . $(ACTIVATE) && \