Skip to content

removed usr and lib from ndk library path in librt recipe #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

removed usr and lib from ndk library path in librt recipe #2606

merged 1 commit into from
May 26, 2022

Conversation

kengoon
Copy link
Contributor

@kengoon kengoon commented May 26, 2022

fix for lxml build error

ld: error: unable to find library -lrt
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
error: command '/usr/bin/ccache' failed with exit status 1

the above error is using this path

/home/<user>/.buildozer/android/platform/android-ndk-r23b/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/arm-linux-androideabi/21/usr/lib

instead of

/home/<user>/.buildozer/android/platform/android-ndk-r23b/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/arm-linux-androideabi/21

@kengoon
removed usr and lib from ndk library path
4487002 
fix for 
```sh
ld: error: unable to find library -lrt
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
error: command '/usr/bin/ccache' failed with exit status 1
```

the above error is using this path
```sh
/home/<user>/.buildozer/android/platform/android-ndk-r23b/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/arm-linux-androideabi/21/usr/lib
```
instead of 
```sh
/home/kengo/.buildozer/android/platform/android-ndk-r23b/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/arm-linux-androideabi/21
```
@AndreMiras
Copy link
Member

OK linking issue, we missed that from the CI because it would generate runtime errors indeed.
Did you get a chance to test the binary runtime this time to be sure the recipe is OK?

@kengoon
Copy link
Contributor Author

kengoon commented May 26, 2022

The build is now successful, I am about to test the apk. I will update soon if it works fine

@kengoon
Copy link
Contributor Author

kengoon commented May 26, 2022 •
edited
Loading

I can confirm that at runtime the binary works perfect

AndreMiras
AndreMiras approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for the fix and the test, let's 🚢

@AndreMiras AndreMiras merged commit 9147848 into kivy:develop May 26, 2022
@misl6
Copy link
Member

misl6 commented May 26, 2022

Hi @kengoon and @AndreMiras

I’m not against these changes (And thank you @kengoon for taking care of it), but please consider that are already targeted via #2586 (which will likely exit the WIP status this weekend) by using the brand-new pythonforandroid.androidndk.AndroidNDK object and the new versioned properties (See https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#sysroot).

@AndreMiras
Copy link
Member

Oh right good point @misl6, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kengoon @AndreMiras @misl6