Skip to content

restrict sh version #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023
Merged

restrict sh version #2746

merged 1 commit into from
Feb 10, 2023

Conversation

HyTurtle
Copy link
Contributor

keep sh version under 2.0 as default behaviour was switched

keep sh version under 2.0 as default behaviour was switched
@misl6
Copy link
Member

misl6 commented Feb 10, 2023

Hi @HyTurtle !

Can you please explain why this is needed?

@HyTurtle
Copy link
Contributor Author

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining!
Let's wait for the CI pipeline to complete, but LGTM.

I guess we should have an emergency release this weekend.

I will then open an issue to remind us that sh.Command usage should be migrated to be future-proof.

@HyTurtle
Copy link
Contributor Author

HyTurtle commented Feb 10, 2023

Sounds like a plan.

closes #2745

@misl6 misl6 merged commit 70fa6dd into kivy:develop Feb 10, 2023
misl6 added a commit that referenced this pull request Feb 11, 2023
* Update `pydantic` recipe

There is [incompatibility](huggingface/transformers#8638) between python > 3.6 and package `dataclasses`.

This error was happening after my compilations: `AttributeError: module 'typing' has no attribute '_ClassVar'`

The fix is removing `dataclasses` from `python_depends`.

I also updated the pydantic version to the newest release `1.10.4`, it can be checked [here](https://github.com/pydantic/pydantic/releases) and its url.

I already compiled my app after applying these changes, and the compilation is working successfully again.

* Restrict sh version to sh>=1.10, <2.0 (#2746)

keep sh version under 2.0 as default behaviour was switched

* Update CHANGELOG.md and update version to 2023.02.10

---------

Co-authored-by: Filipe Marchesini <filipe.marchesini@gmail.com>
Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com>
Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com>
shyamnathp pushed a commit to shyamnathp/python-for-android that referenced this pull request Feb 17, 2023
keep sh version under 2.0 as default behaviour was switched
manuq pushed a commit to endlessm/python-for-android that referenced this pull request Feb 17, 2023
keep sh version under 2.0 as default behaviour was switched
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Feb 27, 2023
keep sh version under 2.0 as default behaviour was switched
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Feb 27, 2023
Restrict sh version to sh>=1.10, <2.0 (kivy#2746)

keep sh version under 2.0 as default behaviour was switched
AndreMiras added a commit that referenced this pull request Aug 13, 2024
AndreMiras added a commit that referenced this pull request Aug 16, 2024
AndreMiras added a commit that referenced this pull request Aug 16, 2024
AndreMiras added a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants