android_api to integer #2765
Merged
android_api to integer #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
requested changes
Mar 12, 2023
Comment on lines
500
to
502
| android_api = int(target.split('-')[1]) | ||
| try: | ||
| int(android_api) |
There was a problem hiding this comment.
Suggested change
| android_api = int(target.split('-')[1]) | |
| try: | |
| int(android_api) | |
| android_api = target.split('-')[1] | |
| try: | |
| android_api = int(android_api) |
There was a problem hiding this comment.
Just after this call, we have a try/except block that checks if the android_api string value is parseable as an int.
Parsing the int from string before that call will lead to a crash, without raising the needed error.
misl6
reviewed
Mar 12, 2023
Comment on lines
504
to
508
| raise ValueError( | ||
| "failed to extract the Android API level from " + | ||
| "build.properties. expected int, got: '" + | ||
| str(android_api) + "'" | ||
| ) |
There was a problem hiding this comment.
Nice, but maybe we can keep the error message?
misl6
added a commit
that referenced
this pull request
May 22, 2023
* Add support for Python 3.10 and make it the default while building hostpython3 and python3 (#2577) * Add support for Python 3.10 and make it the default while building hostpython3 and python3 * Update bugfix version * Add PyAV recipe (#2750) * pyav recipe * flake8 fix * Update pythonforandroid/recipes/av/__init__.py Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> --------- Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> * Add debug loggings for identifying a matching dist (#2751) * Add debug loggings for identifying a matching dist * Fix lint failure on f-string. * Adds flag to support home app (launcher) intent-filter on SDL2 bootstrap (#2761) * Home app functionality * Cleanup * Added --home-app to the docs * Fixed the if statements within the intent-filter * Use io.IOBase for LogFile (#2763) This provides reasonable default implementations for common IO class methods such as isatty(). Closes #2762. * android_api to integer (#2765) * android_api to integer * changes to android_api * changes to android_api * fix #2768 smallIconName null can t be compared to String (#2769) * fix #2768 smallIconName null can t be compared to String * fix: Remove Importance None of notification which is modification from my own fork * fix: Readd Importance_NONE in the notification channel as it s also in upstream p4a * fix tools/liblink: syntax error regression from 22b7dfe * Update pyjnius version in recipe (#2791) * Update Kivy recipe for 2.2.0 (#2793) * Update Kivy recipe for 2.2.0rc1 * Bump to 2.2.0 * Update CHANGELOG.md and bump version to 2023.05.21 --------- Co-authored-by: Dexer <73297572+DexerBR@users.noreply.github.com> Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> Co-authored-by: BitcoinWukong <87334822+BitcoinWukong@users.noreply.github.com> Co-authored-by: Mathias Lindström <kuzeyron@gmail.com> Co-authored-by: Dylan McCall <dylan@dylanmccall.ca> Co-authored-by: Benoît HERVIER <b@rvier.fr> Co-authored-by: SomberNight <somber.night@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller fix when
android_apiwas given as a string but integer is needed and expected.