Skip to content

fix all grammar and spelling issues in releases of 20210113 #98047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix all grammar and spelling issues in releases of 20210113 #98047

merged 1 commit into from
Jan 27, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 14, 2021 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:
use grammar check plugin

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2021
@pacoxu pacoxu changed the title fix all grammer and speel issues in releases of 20210113 fix all grammar and spelling issues in releases of 20210113 Jan 14, 2021
@pacoxu pacoxu mentioned this pull request Jan 14, 2021
Closed
hasheddan
hasheddan approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@dougsland
Copy link
Member

/lgtm

@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2021

/assign @alejandrox1 @cpanato

cpanato
cpanato approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pacoxu pacoxu mentioned this pull request Jan 20, 2021
Closed
@pacoxu pacoxu requested review from cpanato and hasheddan January 21, 2021 07:04
hasheddan
hasheddan approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pacoxu pacoxu requested a review from hasheddan January 25, 2021 11:26
@pacoxu
Copy link
Member Author

pacoxu commented Jan 25, 2021

/assign @alejandrox1

@pacoxu
fix all grammer and speel issues in releases of 20210113
ca2033d 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
@pacoxu pacoxu force-pushed the 1.21/grammer-fixes branch from d122441 to ca2033d Compare January 27, 2021 09:16
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 27, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 27, 2021

After 1.21.0-alpha.2, add another two typo fixes here.

xmudrii
xmudrii approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, pacoxu, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Jan 27, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@pacoxu
Copy link
Member Author

pacoxu commented Jan 27, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit b418bc8 into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
@wilsonehusin
Copy link
Contributor

@pacoxu hmm looks like the 1.21 notes might get overwritten since it's still pre-release right now. for edits on pre-release, can you help us to port the changes on k/sig-release? the CHANGELOG on k/k came from k/sig-release. we'll need to create the mapping and edits for each entry so it won't get overwritten by automation.

@pacoxu
Copy link
Member Author

pacoxu commented Feb 1, 2021

ok @wilsonehusin

@pacoxu pacoxu mentioned this pull request Feb 1, 2021
Closed
@pacoxu pacoxu deleted the 1.21/grammer-fixes branch June 23, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

@cpanato cpanato Awaiting requested review from cpanato

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@dougsland dougsland

@cpanato cpanato

@alejandrox1 alejandrox1

@xmudrii xmudrii

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
8 participants
@pacoxu @dougsland @k8s-ci-robot @wilsonehusin @cpanato @xmudrii @hasheddan @alejandrox1