fix skipped None (getsentry#566)

sergei-iurchenko · untitaker · commit 103d2563d319 · 2019-11-26T16:25:31.000+01:00
Fix getsentry#567
diff --git a/sentry_sdk/integrations/logging.py b/sentry_sdk/integrations/logging.py
@@ -135,6 +135,7 @@ def _logging_to_event_level(levelname):
         "tags",
         "thread",
         "threadName",
+        "stack_info",
     )
 )
 
diff --git a/sentry_sdk/serializer.py b/sentry_sdk/serializer.py
@@ -266,7 +266,7 @@ def _serialize_node_impl(
             # might mutate our dictionary while we're still iterating over it.
             obj = dict(iteritems(obj))
 
-            rv_dict = {}
+            rv_dict = {}  # type: Dict[str, Any]
             i = 0
 
             for k, v in iteritems(obj):
@@ -285,9 +285,8 @@ def _serialize_node_impl(
                     else None,
                     remaining_breadth=remaining_breadth,
                 )
-                if v is not None:
-                    rv_dict[str_k] = v
-                    i += 1
+                rv_dict[str_k] = v
+                i += 1
 
             return rv_dict
 
diff --git a/sentry_sdk/tracing.py b/sentry_sdk/tracing.py
@@ -442,7 +442,11 @@ def record_sql_queries(
 
     query = _format_sql(cursor, query)
 
-    data = {"db.params": params_list, "db.paramstyle": paramstyle}
+    data = {}
+    if params_list is not None:
+        data["db.params"] = params_list
+    if paramstyle is not None:
+        data["db.paramstyle"] = paramstyle
     if executemany:
         data["db.executemany"] = True
 

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,7 @@ def _logging_to_event_level(levelname):`
`135`	`135`	`"tags",`
`136`	`136`	`"thread",`
`137`	`137`	`"threadName",`
	`138`	`+ "stack_info",`
`138`	`139`	`)`
`139`	`140`	`)`
`140`	`141`