fix: fix cloudevent signature callbacks (GoogleCloudPlatform#234)

grant · web-flow · commit 2449956aeef7 · 2020-11-09T14:45:06.000-06:00
Signed-off-by: Grant Timmerman &lt;timmerman+devrel@google.com&gt;
diff --git a/src/invoker.ts b/src/invoker.ts
@@ -147,8 +147,8 @@ export function wrapCloudEventFunction(
       cloudevent = getBinaryCloudEventContext(req);
       cloudevent.data = req.body;
     }
-    // Callback style if user function has more than 2 arguments.
-    if (userFunction!.length > 2) {
+    // Callback style if user function has more than 1 argument.
+    if (userFunction!.length > 1) {
       const fn = userFunction as CloudEventFunctionWithCallback;
       return fn(cloudevent, callback);
     }

Original file line number	Diff line number	Diff line change
`@@ -147,8 +147,8 @@ export function wrapCloudEventFunction(`
`147`	`147`	`cloudevent = getBinaryCloudEventContext(req);`
`148`	`148`	`cloudevent.data = req.body;`
`149`	`149`	`}`
`150`		`- // Callback style if user function has more than 2 arguments.`
`151`		`- if (userFunction!.length > 2) {`
	`150`	`+ // Callback style if user function has more than 1 argument.`
	`151`	`+ if (userFunction!.length > 1) {`
`152`	`152`	`const fn = userFunction as CloudEventFunctionWithCallback;`
`153`	`153`	`return fn(cloudevent, callback);`
`154`	`154`	`}`