Use the ::class notation #3405
Merged
Use the ::class notation #3405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix the namespace with \
|
Do we need the slash at the beginning of each line? |
|
Yes since we're in a namespace. |
|
Correct. Thanks for this answer. |
| @@ -13,7 +13,7 @@ class Kernel extends ConsoleKernel | |||
| * @var array | |||
| */ | |||
| protected $commands = [ | |||
| 'App\Console\Commands\Inspire', | |||
| \App\Console\Commands\Inspire::class, | |||
There was a problem hiding this comment.
Prefer if we imported this.
There was a problem hiding this comment.
What if we have 30 commands ? 😃
That was your argument on the other PR, not having tons of imports at top of file.
|
Local app ::class will be relative or you could import the namespace (I know namespace imports in PHP aren't ideal). So that brings it down to a shorter length and a single import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ::class notation for class references in app/ folder.
Similar to #3403