Introduce DB_PATH for sqlite issue in .env #3729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have a way to set this. |
|
@GrahamCampbell I know that we have Please see my linked comment for the example? |
|
Right, but the env allows us to bypass calling the database_path function. |
|
We also can't make assumptions about the filename. |
|
Thanks for the PR, but I'd suggest you just tweak your own apps to get them how you like them. Everyone likes things setup slightly differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my comment on PR #3698
This PR resolves that issue - though I do have a strong feeling that this could be done a lot better, I simply didn't want to venture into laravel/framework to change the database_path() helper to check for an env('DB_PATH') - though I would imagine that would be somewhat cleaner.