Skip to content

[5.2] Add TokenMismatchException to the dontReport array #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2016
Merged

[5.2] Add TokenMismatchException to the dontReport array #3874

merged 1 commit into from
Aug 16, 2016

Conversation

lancepioch
Copy link
Contributor

@lancepioch lancepioch commented Aug 12, 2016

@GrahamCampbell GrahamCampbell changed the title [5.3] Add TokenMismatchException to the dontReport array [5.2] Add TokenMismatchException to the dontReport array Aug 13, 2016
@taylorotwell taylorotwell merged commit 982e769 into laravel:master Aug 16, 2016
@lancepioch lancepioch deleted the patch-1 branch August 16, 2016 00:45
@bkuhl
Copy link

bkuhl commented Aug 18, 2016

I think this commit should be reverted. When deploying Laravel applications to a highly available environment this exception can be thrown if stickiness is not configured correctly. Adding this to the ignore list masks this error and can make it significantly more difficult for HA deployments to catch this problem.

@lancepioch
Copy link
Contributor Author

lancepioch commented Aug 18, 2016

I feel like it'd be better to recommend against storing sessions in memory like that when you have multiple servers around a load balancer. This error is just so frequently thrown around that it's useless to see it the majority of the time.

ramdanegie pushed a commit to ramdanegie/laravel that referenced this pull request Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants