Skip to content

Conversation

mvdnbrk
Copy link
Contributor

@mvdnbrk mvdnbrk commented Apr 5, 2019

The Event facade is not used in the EventServiceProvider class.

@4refael
Copy link
Contributor

4refael commented Apr 5, 2019

It's there intentionally #3916

@azeyrx
Copy link

azeyrx commented Apr 5, 2019

That's true, but beginners don't do anything with the service provider either.
And it is loaded unnecessarily, which is at the expense of performance.

@mvdnbrk
Copy link
Contributor Author

mvdnbrk commented Apr 5, 2019

Ah, didn't see the other PRs.

I will be using Auto Event Discovery from now on.
So for me it's really unnecessary to import that facade by default.

Let some smart guy decide over here ;-)

@taylorotwell
Copy link
Member

I don't think a use statement has a performance hit. PHP doesn't even verify if the "use" target exists at all.

@mvdnbrk mvdnbrk deleted the mvdnbrk-patch-1 branch April 5, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants