Skip to content

Email validation allows incorrect emailaddress #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GertjanBrouwer opened this issue Jun 12, 2019 · 3 comments
Closed

Email validation allows incorrect emailaddress #929

GertjanBrouwer opened this issue Jun 12, 2019 · 3 comments

Comments

@GertjanBrouwer
Copy link

GertjanBrouwer commented Jun 12, 2019 •
edited
Loading

  • Lumen Version: 5.8.*
  • PHP Version: 7.3
  • Database Driver & Version: MariaDB

Description:

When using the Lumen validator for emailadresses it will allow an emailadress that is not valid.
The emailaddress used: herr@ notice the space after the @-sign.

Steps To Reproduce:

$validator = Validator::make(['email' => 'herr@ '], [
    'email' => 'required|email',
]);

dd($validator->fails()); // returns false, which is not correct
@SPie
Copy link
Contributor

SPie commented Jun 13, 2019

I'm not sure if you made a mistake in your 'Steps to Reproduce' because $validator->fails() returns true on an invalid email address would be the expected behaviour.
Otherwise, this could be your issue.

@GertjanBrouwer
Copy link
Author

I'm not sure if you made a mistake in your 'Steps to Reproduce' because $validator->fails() returns true on an invalid email address would be the expected behaviour.
Otherwise, this could be your issue.

You're right. It returned false. Just a typo

@driesvints
Copy link
Member

Hi there, this is a valid email address. Please see laravel/framework#28233 and tons of other issues in the framework repo about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driesvints @SPie @GertjanBrouwer