-
Notifications
You must be signed in to change notification settings - Fork 415
Lumen Exception Handler is not compatible with Symfony 4.4 (when it goes stable) #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@crynobone can you point to the PR where that change was made? I can't find any info on it 🤔 |
From symfony example, they been changing it to use |
Here's the PR symfony/symfony#31065 for more detail |
Urgh. This is unfortunate. I guess we'd better wait until 4.4 is out and then implement the changes? |
@crynobone I can't spot the removal of the |
@crynobone no problem. I've found the commit and left a message on the PR. https://github.com/symfony/symfony/pull/31065/files#diff-facc3bcdbfaa88c930890ad4713b187dL213 |
Hi, This seems to not work indeed.. |
Description:
Lumen 5.8 allows installation of
symfony/debug
4.4
which introduce a deprecation and removal ofSymfony\Component\Debug\ExceptionHandler::getContent()
and this is not detected by Travis due toprefer-stable=true
.Steps To Reproduce:
Remove
prefer-stable=true
, runcomposer update
and execute phpunit.The text was updated successfully, but these errors were encountered: