modify tests: evaluate 'hasTime' in date props

johguentner · johguentner · commit 0a07217d4b04 · 2022-07-11T10:21:11.000+02:00
- add date with and without time in page response stub
- assert true and false, if time is included
- add these two additional properties within assert count of page results
diff --git a/tests/EndpointPagesTest.php b/tests/EndpointPagesTest.php
@@ -69,9 +69,13 @@ public function it_returns_page_entity_with_filled_properties()
         // check properties
         $this->assertSame('Notion Is Awesome', $pageResult->getTitle());
         $this->assertSame('page', $pageResult->getObjectType());
-        $this->assertCount(7, $pageResult->getRawProperties());
-        $this->assertCount(7, $pageResult->getProperties());
-        $this->assertCount(7, $pageResult->getPropertyKeys());
+        $this->assertCount(9, $pageResult->getRawProperties());
+        $this->assertCount(9, $pageResult->getProperties());
+        $this->assertCount(9, $pageResult->getPropertyKeys());
+
+        // check date and datetime properties
+        $this->assertTrue($pageResult->getProperty('DateWithTime')->hasTime());
+        $this->assertFalse($pageResult->getProperty('DateWithoutTime')->hasTime());
 
         $this->assertInstanceOf(Carbon::class, $pageResult->getCreatedTime());
         $this->assertInstanceOf(Carbon::class, $pageResult->getLastEditedTime());
@@ -179,6 +183,7 @@ public function it_assembles_properties_for_a_new_page()
         $this->assertTrue($dateRangeProp->isRange());
         $this->assertEquals($dateRangeStartValue, $dateRangeProp->getStart());
         $this->assertEquals($dateRangeEndValue, $dateRangeProp->getEnd());
+        $this->assertFalse($dateRangeProp->hasTime());
         $this->assertJson($dateRangeProp->asText());
         $this->assertStringContainsString($dateRangeStartValue->format('Y-m-d H:i:s'), $dateRangeProp->asText());
         $this->assertStringContainsString($dateRangeEndValue->format('Y-m-d H:i:s'), $dateRangeProp->asText());
@@ -200,6 +205,7 @@ public function it_assembles_properties_for_a_new_page()
         $this->assertTrue($dateTimeRangeProp->isRange());
         $this->assertEquals($dateRangeStartValue, $dateTimeRangeProp->getStart());
         $this->assertEquals($dateRangeEndValue, $dateTimeRangeProp->getEnd());
+        $this->assertTrue($dateTimeRangeProp->hasTime());
         $this->assertJson($dateTimeRangeProp->asText());
         $this->assertStringContainsString($dateRangeStartValue->format('Y-m-d H:i:s'), $dateTimeRangeProp->asText());
         $this->assertStringContainsString($dateRangeEndValue->format('Y-m-d H:i:s'), $dateTimeRangeProp->asText());
@@ -216,6 +222,8 @@ public function it_assembles_properties_for_a_new_page()
         $this->assertInstanceOf(RichDate::class, $dateProp->getContent());
         $this->assertFalse($dateProp->isRange());
         $this->assertEquals($dateValue, $dateProp->getStart());
+        $this->assertNull($dateProp->getEnd());
+        $this->assertFalse($dateProp->hasTime());
         $dateContent = $dateProp->getRawContent();
         $this->assertArrayHasKey('date', $dateContent);
         $this->assertCount(1, $dateContent['date']);
@@ -227,6 +235,8 @@ public function it_assembles_properties_for_a_new_page()
         $this->assertInstanceOf(RichDate::class, $dateTimeProp->getContent());
         $this->assertFalse($dateTimeProp->isRange());
         $this->assertEquals($dateValue, $dateTimeProp->getStart());
+        $this->assertNull($dateTimeProp->getEnd());
+        $this->assertTrue($dateTimeProp->hasTime());
         $dateTimeContent = $dateTimeProp->getRawContent();
         $this->assertArrayHasKey('date', $dateTimeContent);
         $this->assertCount(1, $dateTimeContent['date']);
diff --git a/tests/stubs/endpoints/pages/response_specific_200.json b/tests/stubs/endpoints/pages/response_specific_200.json
@@ -40,6 +40,24 @@
                 }
             ]
         },
+        "DateWithTime":{
+            "id": ">d{D",
+            "type": "date",
+            "date": {
+                "start": "2021-05-14T00:00:00.000+00:00",
+                "end": "2021-06-14T00:00:00.000+00:00",
+                "time_zone": null
+            }
+        },
+        "DateWithoutTime":{
+            "id": ">c{d",
+            "type": "date",
+            "date": {
+                "start": "2021-05-14",
+                "end": "2021-06-14",
+                "time_zone": null
+            }
+        },
         "SelectColumn": {
             "id": "nKff",
             "type": "select",
