Add support for failover cache #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2021
b5f36e4 to
59dc165
Compare
|
@mikefrancis anything you need from me to move this forward? |
|
Sorry @dshafik - I think this needs rebasing or updating first. Once that's done I'll take a look at this over the weekend :) |
|
@mikefrancis ah, because you merged #24 first, I'll make the changes ASAP |
59dc165 to
270eb9f
Compare
mxkxf
reviewed
Feb 21, 2021
mxkxf
reviewed
Feb 21, 2021
270eb9f to
ff329d6
Compare
- Changes cache TTL default to 15s, the standard default - Add unleash.cache.failover option that will pull the last successful result from the cache - This setting is independent of regular caching - The cache is always stored, to allow enabling the feature during a failure incidence - This change also moves the requests for features out of the constructor - Possible to use in Facades - Still "cached" for the lifetime of the Unleash object
ff329d6 to
853af1f
Compare
mxkxf
approved these changes
Feb 25, 2021
|
Thanks @dshafik ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failover cache will ensure that the last successful set of features fetched from Unleash are always returned if the unleash server is down.