FIX: Array.values(axes=0) (closes #1093)

gdementen · gdementen · commit 17e64237b793 · 2024-07-16T15:28:05.000+02:00
diff --git a/doc/source/changes/version_0_34_3.rst.inc b/doc/source/changes/version_0_34_3.rst.inc
@@ -62,3 +62,6 @@ Fixes
 
 * fixed copying a sheet from one Excel workbook to another when the destination
   sheet is given by position (closes :issue:`1092`).
+
+* fixed :py:obj:`Array.values()` and :py:obj:`Array.items()` on the first axis given by position.
+  (e.g. `my_array.values(axes=0)`). Closes :issue:`1093`.
diff --git a/larray/core/array.py b/larray/core/array.py
@@ -3434,13 +3434,14 @@ def values(self, axes=None, ascending=True) -> Union[np.ndarray, List['Array'],
             combined = np.ravel(self.data)
             # combined[::-1] *is* indexable
             return combined if ascending else combined[::-1]
-        elif not axes:
-            # empty axes list
-            return [self]
 
         if not isinstance(axes, (tuple, list, AxisCollection)):
             axes = (axes,)
 
+        if len(axes) == 0:
+            # empty axes list
+            return [self]
+
         axes = self.axes[axes]
         # move axes in front
         transposed = self.transpose(axes)
diff --git a/larray/tests/test_array.py b/larray/tests/test_array.py
@@ -336,6 +336,11 @@ def test_values():
     res = list(values)
     assert_larray_equal(res[0], arr)
 
+    # issue 1093
+    values = arr.values(0)
+    res = list(values)
+    assert_larray_equal(res[0], arr['a0'])
+
 
 def test_items():
     arr = ndtest((2, 2))
@@ -399,6 +404,14 @@ def test_items():
     assert key == (b.i[0],)
     assert_larray_equal(value, arr['b0'])
 
+    # issue 1093
+    items = arr.items(0)
+    items_list = list(items)
+    key, value = items_list[0]
+    assert key == (a.i[0],)
+    assert_larray_equal(value, arr['a0'])
+
+
 
 def test_rename(array):
     new_array = array.rename('c', 'c2')
