Skip to content

Commit 3372fb9

Browse files
committed
actually check the result of some Session IO to xlsx tests
(ie check that array order is preserved)
1 parent 64c84bc commit 3372fb9

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

larray/tests/test_session.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,11 @@ def test_h5_io(self):
146146
self.assertEqual(list(s.keys()), ['e', 'f'])
147147

148148
def test_xlsx_pandas_io(self):
149-
self.session.save(abspath('test_session.xlsx'), engine='pandas_excel')
149+
fpath = abspath('test_session.xlsx')
150+
self.session.save(fpath, engine='pandas_excel')
151+
s = Session()
152+
s.load(fpath, engine='pandas_excel')
153+
self.assertEqual(list(s.keys()), ['e', 'g', 'f'])
150154

151155
fpath = abspath('test_session_ef.xlsx')
152156
self.session.save(fpath, ['e', 'f'], engine='pandas_excel')
@@ -156,7 +160,12 @@ def test_xlsx_pandas_io(self):
156160

157161
@pytest.mark.skipif(xw is None, reason="xlwings is not available")
158162
def test_xlsx_xlwings_io(self):
159-
self.session.save(abspath('test_session_xw.xlsx'), engine='xlwings_excel')
163+
fpath = abspath('test_session_xw.xlsx')
164+
self.session.save(fpath, engine='xlwings_excel')
165+
s = Session()
166+
s.load(fpath, engine='xlwings_excel')
167+
# ordering is only kept if the file did not exist previously (otherwise the ordering is left intact)
168+
self.assertEqual(list(s.keys()), ['e', 'g', 'f'])
160169

161170
fpath = abspath('test_session_ef_xw.xlsx')
162171
self.session.save(fpath, ['e', 'f'], engine='xlwings_excel')

0 commit comments

Comments
 (0)