fix #913 : fixed *_by functions returning the same value as if no axis was passed when specifying all axes

alixdamman · alixdamman · commit 78155f007ee1 · 2021-02-24T08:34:30.000+01:00
diff --git a/doc/source/changes/version_0_33.rst.inc b/doc/source/changes/version_0_33.rst.inc
@@ -59,3 +59,6 @@ Fixes
 ^^^^^
 
 * fixed an edge case for group aggregates and labels in reverse order (closes :issue:`868`).
+
+* fixed *_by functions returning the same value as if no axis was passed when specifying all axes
+  (closes :issue:`913`)
diff --git a/larray/core/array.py b/larray/core/array.py
@@ -2832,7 +2832,9 @@ def is_or_contains_group(o):
     def _aggregate(self, op, args, kwargs=None, keepaxes=False, by_agg=False, commutative=False,
                    out=None, extra_kwargs={}):
         operations = self._prepare_aggregate(op, args, kwargs, commutative, stack_depth=3)
-        if by_agg and operations != self.axes:
+
+        total_len_args = len(args) + len(kwargs) if kwargs is not None else 0
+        if by_agg and total_len_args:
             operations = self._by_args_to_normal_agg_args(operations)
 
         res = self
diff --git a/larray/tests/test_array.py b/larray/tests/test_array.py
@@ -2397,6 +2397,10 @@ def test_agg_by(array):
     assert array.sum_by().shape == ()
     assert array.sum_by() == array.sum()
 
+    # all axes
+    assert array.sum_by(geo, age, lipro, sex).equals(array)
+    assert array.sum_by(age, geo, sex, lipro).equals(array)
+
     # a) group aggregate on a fresh array
 
     # a.1) one group
