FIX: fixed converting a scalar Array (an Array with 0 dimensions) to string with numpy 1.23+

gdementen · gdementen · commit 85cfbd4cf065 · 2024-07-16T15:28:05.000+02:00
this was deprecated from numpy 1.16, but this escaped our radar because our test was buggy
diff --git a/doc/source/changes/version_0_34_3.rst.inc b/doc/source/changes/version_0_34_3.rst.inc
@@ -56,3 +56,5 @@ Fixes
 ^^^^^
 
 * fixed something (closes :issue:`1`).
+
+* fixed converting a scalar Array (an Array with 0 dimensions) to string with numpy 1.22+.
diff --git a/larray/core/array.py b/larray/core/array.py
@@ -2446,9 +2446,9 @@ def ignore_labels(self, axes=None) -> 'Array':
     drop_labels = renamed_to(ignore_labels, 'drop_labels', raise_error=True)
 
     def __str__(self) -> str:
-        if not self.ndim:
-            return str(np.asscalar(self))
-        elif not len(self):
+        if self.ndim == 0:
+            return str(self.data.item())
+        elif len(self) == 0:
             return 'Array([])'
         else:
             table = self.dump(maxlines=_OPTIONS[DISPLAY_MAXLINES], edgeitems=_OPTIONS[DISPLAY_EDGEITEMS],
diff --git a/larray/tests/test_array.py b/larray/tests/test_array.py
@@ -435,8 +435,9 @@ def test_info(array, meta):
 def test_str(small_array, array):
     d3 = d['d1:d3']
 
-    # zero dimension / scalar
-    assert str(small_array[d['d1'], c['c1']]) == "6"
+    # zero dimension / scalar Array
+    scalar_array = Array(42)
+    assert str(scalar_array) == "42"
 
     # empty / len 0 first dimension
     assert str(small_array[c[[]]]) == "Array([])"
