modified the LArray.percent() method because it may lead to negative values if the array contains integer values close to the highest integer value available

alixdamman · alixdamman · commit 8c61c8661630 · 2019-10-08T10:14:02.000+02:00
diff --git a/larray/core/array.py b/larray/core/array.py
@@ -3789,8 +3789,7 @@ def percent(self, *axes):
              BE  40.0  60.0
              FO  20.0  80.0
         """
-        # dividing by self.sum(*axes) * 0.01 would be faster in many cases but I suspect it loose more precision.
-        return self * 100 / self.sum(*axes)
+        return self * 100.0 / self.sum(*axes)
 
     # aggregate method decorator
     def _decorate_agg_method(npfunc, nanfunc=None, commutative=False, by_agg=False, extra_kwargs=[],
diff --git a/larray/tests/test_array.py b/larray/tests/test_array.py
@@ -2484,15 +2484,15 @@ def test_percent(array):
     reg = array.sum(age, sex, regions)
 
     percent = reg.percent()
-    assert_array_equal(percent, reg * 100 / reg.sum(geo, lipro))
+    assert_array_equal(percent, (reg * 100.0 / reg.sum(geo, lipro)))
     assert percent.shape == (3, 15)
 
     percent = reg.percent(geo)
-    assert_array_equal(percent, reg * 100 / reg.sum(geo))
+    assert_array_equal(percent, (reg * 100.0 / reg.sum(geo)))
     assert percent.shape == (3, 15)
 
     percent = reg.percent(geo, lipro)
-    assert_array_equal(percent, reg * 100 / reg.sum(geo, lipro))
+    assert_array_equal(percent, (reg * 100.0 / reg.sum(geo, lipro)))
     assert percent.shape == (3, 15)
     assert round(abs(percent.sum() - 100.0), 7) == 0
 
