FIX: fixed copying a sheet when the target key is an int (closes #1092)

gdementen · gdementen · commit afb9fc40c42a · 2024-07-16T15:28:05.000+02:00
diff --git a/doc/source/changes/version_0_34_3.rst.inc b/doc/source/changes/version_0_34_3.rst.inc
@@ -58,3 +58,6 @@ Fixes
 * fixed something (closes :issue:`1`).
 
 * fixed converting a scalar Array (an Array with 0 dimensions) to string with numpy 1.22+.
+
+* fixed copying a sheet from one Excel workbook to another when the destination
+  sheet is given by position (closes :issue:`1092`).
diff --git a/larray/inout/xw_excel.py b/larray/inout/xw_excel.py
@@ -239,8 +239,11 @@ def __setitem__(self, key, value):
                 value.xw_sheet.api.Copy(None, target_sheet.api)
                 if key_in_self:
                     target_sheet.delete()
-                # rename the new sheet
-                self[target_idx].name = key
+
+                # rename the new sheet if necessary
+                # if the key is an integer, we keep the name of the source sheet
+                if isinstance(key, str):
+                    self[target_idx].name = key
                 return
             if key_in_self:
                 sheet = self[key]
diff --git a/larray/tests/test_excel.py b/larray/tests/test_excel.py
@@ -128,6 +128,15 @@ def test_setitem(self):
             assert wb.sheet_names() == ['sheet1', 'sheet2', 'sheet3']
             assert wb['sheet2']['A1'].value == 'sheet1 content'
 
+            # reset sheet 3 content (for next test)
+            wb['sheet3'] = 'sheet3 content'
+            assert wb['sheet3']['A1'].value == 'sheet3 content'
+
+            # sheet did exist, Sheet value (int key)
+            wb[1] = wb['sheet3']
+            assert wb.sheet_names() == ['sheet1', 'sheet3 (2)', 'sheet3']
+            assert wb[1]['A1'].value == 'sheet3 content'
+
             with open_excel(visible=False, app="new") as wb2:
                 assert wb.app != wb2.app
                 with must_raise(ValueError, msg="cannot copy a sheet from one instance of Excel to another"):
