You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
raise an error when common axes between filter.axes and array.axes are not equal
behave as if the filter was False where not present (possibly check that filter.axes are subsets of array.axes). I think that numpy previously had the equivalent of this behavior but no longer support this.
align filter.axes with array.axes, so that if filter.axes has more axes (unsure what happens in this case currently) or more labels on common axes, the result has more labels too.
Currently, I think it would be best to implement 1, until we implement align by default for all operations, in which case 3. would make more sense. I might revise my judgment on option 2 if it turns out absolutely necessary to solve #1084.
FWIW, I don't think this is worth blocker priority even though this is a "silent" failure because the extra "combined" axis would be very quickly spotted by users.
The text was updated successfully, but these errors were encountered:
FWIW, for __setitem__, the picture was a bit different: it somehow/somewhat worked: missing keys were considered False and extra keys were ignored as long as the filter was False for them
This is complete junk.
I see three options going forward:
Currently, I think it would be best to implement 1, until we implement align by default for all operations, in which case 3. would make more sense. I might revise my judgment on option 2 if it turns out absolutely necessary to solve #1084.
FWIW, I don't think this is worth blocker priority even though this is a "silent" failure because the extra "combined" axis would be very quickly spotted by users.
The text was updated successfully, but these errors were encountered: