Skip to content

Drop Python 2 support #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alixdamman opened this issue Jan 25, 2018 · 5 comments
Closed

Drop Python 2 support #567

alixdamman opened this issue Jan 25, 2018 · 5 comments
Assignees
@alixdamman
Labels
infrastructure priority: low
Milestone
0.33

Comments

@alixdamman
Copy link
Collaborator

alixdamman commented Jan 25, 2018 •
edited
Loading

@gdementen Not soon but my idea is then to open an issue to implement type hints.
@gdementen
Copy link
Contributor

gdementen commented Jan 25, 2018 •
edited
Loading

Type hints work on python2 too (using comments).

Also, I would like to first drop Python2 support in LIAM2: liam2/liam2#258

@alixdamman
Copy link
Collaborator Author

alixdamman commented Jan 25, 2018 •
edited
Loading

I know but I prefer to implement the Python 3 type hints directly. I prefer to wait until we drop Python 2 support.

@alixdamman alixdamman added this to the nice_to_have milestone Mar 7, 2018
@gdementen gdementen removed this from the nice_to_have milestone Aug 1, 2019
@alixdamman alixdamman added this to the nice_to_have milestone Oct 10, 2019
@alixdamman alixdamman modified the milestones: nice_to_have, 0.33 Feb 20, 2020
@alixdamman
Copy link
Collaborator Author

Given your comment #840 (comment) , Do you mind if I start to work on this?

Of course, I will not merge anything until you released the 0.32.2 version of larray.

@alixdamman alixdamman self-assigned this Feb 20, 2020
@gdementen
Copy link
Contributor

sure, go ahead

@gdementen gdementen changed the title Drop Python 2 support? Drop Python 2 support Feb 20, 2020
@gdementen
Copy link
Contributor

and you can merge this to master too, given that I will need to release from a branch anyway (to avoid introducing #842 in a patch release)

alixdamman added a commit to alixdamman/larray that referenced this issue Feb 20, 2020
@alixdamman
fix larray-project#567 : dropped Python 2 support
bbe7658
alixdamman added a commit to alixdamman/larray that referenced this issue Feb 20, 2020
@alixdamman
fix larray-project#567 : dropped Python 2 support (config files)
2e740d4
alixdamman added a commit to alixdamman/larray that referenced this issue Feb 27, 2020
@alixdamman
fix larray-project#567 :
da73728 
- dropped Python 2 support
- deleted compat.py module
- abc classes now inherit from abc.ABC in abstractbases.py module
gdementen pushed a commit to gdementen/larray that referenced this issue Nov 30, 2021
@alixdamman @gdementen
fix larray-project#567 :
fc786ef 
- dropped Python 2 support
- deleted compat.py module
- abc classes now inherit from abc.ABC in abstractbases.py module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alixdamman alixdamman

Labels
infrastructure priority: low
Projects
None yet
Milestone
0.33
Development

No branches or pull requests
2 participants
@gdementen @alixdamman