Skip to content

make test data smaller #785

Closed
Closed
@gdementen

Description

@gdementen

For a reason which escapes me, population_session.h5 is 3Mb (while the same data in .xlsx is 11.8Kb) and demography.* are a bit large too, making the total size of the larray package larger than I would prefer.

Activity

alixdamman

alixdamman commented on Jun 27, 2019

@alixdamman
Collaborator

In the PR #771 I have started to replace the use of demography dataset by the demography_eurostat dataset (which is actually population_session renamed).

Is demography used in the unittests?

gdementen

gdementen commented on Jun 27, 2019

@gdementen
ContributorAuthor

I don't remember...

alixdamman

alixdamman commented on Jun 27, 2019

@alixdamman
Collaborator

I temporarily changed the name of demography, ran the tests and found that demography is only used in the load_example_data() function and in the tutorial.

However, there is still a weird problem with demography_eurostat.h5. I'll take a look.

alixdamman

alixdamman commented on Jun 27, 2019

@alixdamman
Collaborator

After some tests I discovered that the size of demography_eurostat.h5 is huge because the session contains Axis objects with labels of dtype '<U'.
There is clearly a problem when dumping axes with unicode labels to an HDF5 file.

gdementen

gdementen commented on Jun 27, 2019

@gdementen
ContributorAuthor

can we solve this?

alixdamman

alixdamman commented on Jun 27, 2019

@alixdamman
Collaborator

We need to convert unicode labels to bytes

added 2 commits that reference this issue on Aug 5, 2019
51231e1
07a3db7
added this to the 0.32 milestone on Aug 13, 2019
added a commit that references this issue on Aug 26, 2019
83f3a4e
added 2 commits that reference this issue on Sep 23, 2019
fd666c6
918dbbb

5 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      make test data smaller · Issue #785 · larray-project/larray