Skip to content

Commit 9619f71

Browse files
committed
changed release step funcs to take keyword arguments instead of a single config argument
this requires **extra_kwargs everywhere (which is ugly) but makes the code more maintainable (as it is much more obvious which step func needs what) and makes it easier to call those functions standalone
1 parent 9f5dc3d commit 9619f71

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

make_release.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@
2525
ONLINE_DOC = None
2626

2727

28-
def update_version_in_json_used_by_menuinst(config):
29-
chdir(config['build_dir'])
28+
def update_version_in_json_used_by_menuinst(build_dir, release_name, package_name, **extra_kwargs):
29+
chdir(build_dir)
3030

31-
version = short(config['release_name'])
32-
package_name = config['package_name']
31+
version = short(release_name)
3332
menuinst_file = join('condarecipe', package_name, 'larray-editor.json')
3433

3534
with open(menuinst_file) as mf:

0 commit comments

Comments
 (0)