fix: previous parameter value is not a number (coder#12246)

mtojek · web-flow · commit c230bcf5ca94 · 2024-02-21T15:44:45.000+01:00
diff --git a/codersdk/richparameters.go b/codersdk/richparameters.go
@@ -60,7 +60,7 @@ func validateBuildParameter(richParameter TemplateVersionParameter, buildParamet
 		value = richParameter.DefaultValue
 	}
 
-	if lastBuildParameter != nil && richParameter.Type == "number" && len(richParameter.ValidationMonotonic) > 0 {
+	if lastBuildParameter != nil && lastBuildParameter.Value != "" && richParameter.Type == "number" && len(richParameter.ValidationMonotonic) > 0 {
 		prev, err := strconv.Atoi(lastBuildParameter.Value)
 		if err != nil {
 			return xerrors.Errorf("previous parameter value is not a number: %s", lastBuildParameter.Value)
diff --git a/codersdk/richparameters_test.go b/codersdk/richparameters_test.go
@@ -309,6 +309,26 @@ func TestRichParameterValidation(t *testing.T) {
 	})
 }
 
+func TestParameterResolver_ValidateResolve_EmptyString_Monotonic(t *testing.T) {
+	t.Parallel()
+	uut := codersdk.ParameterResolver{
+		Rich: []codersdk.WorkspaceBuildParameter{{Name: "n", Value: ""}},
+	}
+	p := codersdk.TemplateVersionParameter{
+		Name:                "n",
+		Type:                "number",
+		Mutable:             true,
+		DefaultValue:        "0",
+		ValidationMonotonic: codersdk.MonotonicOrderIncreasing,
+	}
+	v, err := uut.ValidateResolve(p, &codersdk.WorkspaceBuildParameter{
+		Name:  "n",
+		Value: "1",
+	})
+	require.NoError(t, err)
+	require.Equal(t, "1", v)
+}
+
 func TestParameterResolver_ValidateResolve_Ephemeral_OverridePrevious(t *testing.T) {
 	t.Parallel()
 	uut := codersdk.ParameterResolver{

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ func validateBuildParameter(richParameter TemplateVersionParameter, buildParamet`
`60`	`60`	`value = richParameter.DefaultValue`
`61`	`61`	`}`
`62`	`62`
`63`		`- if lastBuildParameter != nil && richParameter.Type == "number" && len(richParameter.ValidationMonotonic) > 0 {`
	`63`	`+ if lastBuildParameter != nil && lastBuildParameter.Value != "" && richParameter.Type == "number" && len(richParameter.ValidationMonotonic) > 0 {`
`64`	`64`	`prev, err := strconv.Atoi(lastBuildParameter.Value)`
`65`	`65`	`if err != nil {`
`66`	`66`	`return xerrors.Errorf("previous parameter value is not a number: %s", lastBuildParameter.Value)`