From fc02e7aa164246eedfcf0a07c1d3f6cbd7770699 Mon Sep 17 00:00:00 2001 From: Abdulaziz Ali Date: Tue, 4 Aug 2020 21:32:03 +0000 Subject: [PATCH 1/3] fix linting errors on #my_inject --- spec/main_spec.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/spec/main_spec.rb b/spec/main_spec.rb index 0831f9b..26ddc7e 100644 --- a/spec/main_spec.rb +++ b/spec/main_spec.rb @@ -219,10 +219,7 @@ end it 'should return the longest word' do - longest = str_ary.inject do |memo, word| - memo.length > word.length ? memo : word - end - expect(longest).to eql('Sky-Light') + expect( str_ary.inject { |memo, word| memo.length > word.length ? memo : word } ).to eql('Sky-Light') end it 'should return the longest wor' do @@ -234,7 +231,8 @@ end it 'should not mutate the original value' do - expect(number_ary.inject { |product, n| product * n }).to eql([5, 6, 7, 8, 9, 10]) + number_ary.my_inject { |product, n| product * n } + expect(number_ary).to eql([5, 6, 7, 8, 9, 10]) end end From 174f7f30820f7a4ad9e9ae2726076cb12d4a9d48 Mon Sep 17 00:00:00 2001 From: Abdulaziz Ali Date: Tue, 4 Aug 2020 21:42:20 +0000 Subject: [PATCH 2/3] fix Layout/SpaceInsideParens error on '#my_inject longest word' test --- spec/main_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/main_spec.rb b/spec/main_spec.rb index 26ddc7e..2c74d1f 100644 --- a/spec/main_spec.rb +++ b/spec/main_spec.rb @@ -219,7 +219,7 @@ end it 'should return the longest word' do - expect( str_ary.inject { |memo, word| memo.length > word.length ? memo : word } ).to eql('Sky-Light') + expect(str_ary.inject { |memo, word| memo.length > word.length ? memo : word }).to eql('Sky-Light') end it 'should return the longest wor' do From 27567ff066a6a90758588eb4a39341f2a05498d8 Mon Sep 17 00:00:00 2001 From: Abdulaziz Ali Date: Wed, 2 Mar 2022 00:31:57 -0600 Subject: [PATCH 3/3] update readme. --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index b1a7ce9..35bbf87 100644 --- a/README.md +++ b/README.md @@ -71,9 +71,6 @@ Feel free to check the [issues page](issues/). Give a ⭐️ if you like this project! -## Acknowledgments - -- [Thanks for Microverse][https://github.com/microverseinc] ## 📝 License