BUG#35015758: COM_QUIT should not be called in the connection phase

oscpache · oscpache · commit 18315f5b8274 · 2023-01-30T09:10:22.000-06:00
Connector/Python will call CMD_QUIT, close the socket connection,
and raise the right exception if something goes wrong in the
connection phase. However, by calling CMD_QUIT in this phase,
the server will interpret it as a "Bad Message" as the connection
never made it to the command phase, hence CMD_QUIT is an invalid move.

With this patch, CMD_QUIT is not called if something goes wrong in
the connection phase.

Change-Id: I845b21ed5f14911e40bdd1a106291acbafc619e4
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -15,6 +15,7 @@ v8.0.33
 - WL#15483: Support OCI ephemeral key-based authentication
 - WL#15435: Improve the logging system
 - WL#15401: Support for type hints in module mysqlx
+- BUG#35015758: COM_QUIT should not be called in the connection phase
 - BUG#31355895: Fix slow executemany() with insert statements
 - BUG#30103652: Connector/Python ClientFlag SESION_TRACK is a misspelling
 - BUG#27489972: Several COM_% commands have been deprecated
diff --git a/lib/mysql/connector/connection.py b/lib/mysql/connector/connection.py
@@ -585,7 +585,7 @@ def _open_connection(self) -> None:
             self._socket.set_connection_timeout(None)
         except Exception:
             # close socket
-            self.close()
+            self._socket.close_connection()
             raise
 
         if (
