Skip to content

Commit 296fbac

Browse files
Ensure that the engine is destroyed when 'EngineBindings.detach' in the multiple_flutters example on Android (flutter#969)
1 parent 5b0a6be commit 296fbac

File tree

1 file changed

+1
-2
lines changed
  • add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters

1 file changed

+1
-2
lines changed

add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ class EngineBindings(activity: Activity, delegate: EngineBindingsDelegate, entry
7474
* This tears down the messaging connections on the platform channel and the DataModel.
7575
*/
7676
fun detach() {
77-
// TODO: Uncomment after https://github.com/flutter/engine/pull/24644 is on stable.
78-
// engine.destroy();
77+
engine.destroy();
7978
DataModel.instance.removeObserver(this)
8079
channel.setMethodCallHandler(null)
8180
}

0 commit comments

Comments
 (0)