[CI]: dart analyze --fatal-infos (flutter#954)

domesticmouse · web-flow · commit bdf7ad36da6e · 2021-12-01T12:10:44.000+10:00
diff --git a/experimental/linting_tool/lib/pages/default_rules_page.dart b/experimental/linting_tool/lib/pages/default_rules_page.dart
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import 'package:flutter/material.dart';
+import 'package:flutter/services.dart' show SystemUiOverlayStyle;
 import 'package:linting_tool/layout/adaptive.dart';
 import 'package:linting_tool/model/profile.dart';
 import 'package:linting_tool/widgets/lint_expansion_tile.dart';
@@ -51,7 +52,7 @@ class DefaultRulesPage extends StatelessWidget {
         leadingWidth: 160.0,
         toolbarHeight: 38.0,
         backgroundColor: Colors.white,
-        brightness: Brightness.light,
+        systemOverlayStyle: SystemUiOverlayStyle.dark,
       ),
       body: ListView.separated(
         padding: EdgeInsetsDirectional.only(
diff --git a/experimental/linting_tool/lib/pages/rules_page.dart b/experimental/linting_tool/lib/pages/rules_page.dart
@@ -4,6 +4,7 @@
 
 import 'package:context_menus/context_menus.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter/services.dart' show SystemUiOverlayStyle;
 import 'package:linting_tool/layout/adaptive.dart';
 import 'package:linting_tool/model/editing_controller.dart';
 import 'package:linting_tool/model/profiles_store.dart';
@@ -57,7 +58,7 @@ class RulesPage extends StatelessWidget {
         leadingWidth: 160.0,
         toolbarHeight: 38.0,
         backgroundColor: Colors.white,
-        brightness: Brightness.light,
+        systemOverlayStyle: SystemUiOverlayStyle.dark,
       ),
 
       /// ContextMenuOverlay is required to show
diff --git a/experimental/linting_tool/lib/widgets/adaptive_nav.dart b/experimental/linting_tool/lib/widgets/adaptive_nav.dart
@@ -6,6 +6,7 @@ import 'dart:math' as math;
 
 import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
+import 'package:flutter/services.dart' show SystemUiOverlayStyle;
 import 'package:linting_tool/layout/adaptive.dart';
 import 'package:linting_tool/pages/default_lints_page.dart';
 import 'package:linting_tool/pages/home_page.dart';
@@ -103,7 +104,7 @@ class _NavViewState extends State<_NavView> {
         ),
         toolbarHeight: 38.0,
         backgroundColor: Colors.white,
-        brightness: Brightness.light,
+        systemOverlayStyle: SystemUiOverlayStyle.dark,
       ),
       body: Row(
         children: [
diff --git a/experimental/linting_tool/macos/Podfile.lock b/experimental/linting_tool/macos/Podfile.lock
@@ -31,10 +31,10 @@ EXTERNAL SOURCES:
 SPEC CHECKSUMS:
   file_selector_macos: ff6dc948d4ddd34e8602a1f60b7d0b4cc6051a47
   FlutterMacOS: 57701585bf7de1b3fc2bb61f6378d73bbdea8424
-  path_provider_macos: a0a3fd666cb7cd0448e936fb4abad4052961002b
+  path_provider_macos: 160cab0d5461f0c0e02995469a98f24bdb9a3f1f
   url_launcher_macos: 45af3d61de06997666568a7149c1be98b41c95d4
   window_size: 339dafa0b27a95a62a843042038fa6c3c48de195
 
 PODFILE CHECKSUM: 6eac6b3292e5142cfc23bdeb71848a40ec51c14c
 
-COCOAPODS: 1.10.2
+COCOAPODS: 1.11.0
diff --git a/experimental/linting_tool/pubspec.lock b/experimental/linting_tool/pubspec.lock
@@ -678,7 +678,7 @@ packages:
       name: url_launcher
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "6.0.16"
+    version: "6.0.17"
   url_launcher_android:
     dependency: transitive
     description:
@@ -720,7 +720,7 @@ packages:
       name: url_launcher_web
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.4"
+    version: "2.0.5"
   url_launcher_windows:
     dependency: transitive
     description:
diff --git a/platform_design/lib/main.dart b/platform_design/lib/main.dart
@@ -36,7 +36,7 @@ class MyAdaptingApp extends StatelessWidget {
           child: Material(child: child),
         );
       },
-      // ignore: use_key_in_widget_constructors
+      // ignore: use_key_in_widget_constructors, prefer_const_constructors
       home: PlatformAdaptingHomePage(),
     );
   }
diff --git a/tool/flutter_ci_script_shared.sh b/tool/flutter_ci_script_shared.sh
@@ -12,7 +12,11 @@ function ci_projects () {
         flutter pub get
 
         # Run the analyzer to find any static analysis issues.
-        dart analyze
+        if [ "$channel" == 'stable' ]; then
+            dart analyze --fatal-infos
+        else
+            dart analyze
+        fi
 
         # Run the formatter on all the dart files to make sure everything's linted.
         dart format --output none --set-exit-if-changed .

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ class MyAdaptingApp extends StatelessWidget {`
`36`	`36`	`child: Material(child: child),`
`37`	`37`	`);`
`38`	`38`	`},`
`39`		`- // ignore: use_key_in_widget_constructors`
	`39`	`+ // ignore: use_key_in_widget_constructors, prefer_const_constructors`
`40`	`40`	`home: PlatformAdaptingHomePage(),`
`41`	`41`	`);`
`42`	`42`	`}`