fix(deps): more robust isInstalled

Guillaume Chau · Guillaume Chau · commit 9079d3e1e566 · 2018-08-07T00:50:09.000+02:00
diff --git a/packages/@vue/cli-ui/apollo-server/connectors/dependencies.js b/packages/@vue/cli-ui/apollo-server/connectors/dependencies.js
@@ -60,7 +60,7 @@ function findDependencies (deps, type, file, context) {
     id => ({
       id,
       versionRange: deps[id],
-      installed: fs.existsSync(getPath({ id, file })),
+      installed: isInstalled({ id, file }),
       website: getLink({ id, file }, context),
       type,
       baseFir: file
@@ -70,9 +70,15 @@ function findDependencies (deps, type, file, context) {
 
 function getPath ({ id, file = cwd.get() }) {
   const filePath = resolveModule(path.join(id, 'package.json'), file)
+  if (!filePath) return
   return resolveModuleRoot(filePath, id)
 }
 
+function isInstalled ({ id, file = cwd.get() }) {
+  const resolvedPath = getPath({ id, file })
+  return resolvedPath && fs.existsSync(resolvedPath)
+}
+
 function readPackage ({ id, file }, context) {
   try {
     return folders.readPackage(getPath({ id, file }), context)
