fix v-repeat value sync for null and boolean values (fix vuejs#1108)

yyx990803 · yyx990803 · commit f80276395d67 · 2015-07-31T16:07:00.000-04:00
diff --git a/src/directives/repeat.js b/src/directives/repeat.js
@@ -386,12 +386,8 @@ module.exports = {
       this.cacheVm(raw, vm, index, this.converted ? meta.$key : null)
     }
     // sync back changes for two-way bindings of primitive values
-    var type = typeof raw
     var dir = this
-    if (
-      this.rawType === 'object' &&
-      (type === 'string' || type === 'number')
-    ) {
+    if (this.rawType === 'object' && isPrimitive(raw)) {
       vm.$watch(alias || '$value', function (val) {
         if (dir.filters) {
           process.env.NODE_ENV !== 'production' && _.warn(
@@ -740,3 +736,19 @@ function toRefObject (vms) {
   }
   return ref
 }
+
+/**
+ * Check if a value is a primitive one:
+ * String, Number, Boolean, null or undefined.
+ *
+ * @param {*} value
+ * @return {Boolean}
+ */
+
+function isPrimitive (value) {
+  var type = typeof value
+  return value == null ||
+    type === 'string' ||
+    type === 'number' ||
+    type === 'boolean'
+}
diff --git a/test/unit/specs/directives/repeat_spec.js b/test/unit/specs/directives/repeat_spec.js
@@ -669,19 +669,23 @@ if (_.inBrowser) {
           '<div v-repeat="obj">{{$value}}</div>' +
           '<div v-repeat="val:vals">{{val}}</div>',
         data: {
-          items: ['a', 'b'],
+          items: ['a', true],
           obj: { foo: 'a', bar: 'b' },
-          vals: [1, 2]
+          vals: [1, null]
         }
       })
       vm.$children[0].$value = 'c'
+      vm.$children[1].$value = 'd'
       var key = vm.$children[2].$key
-      vm.$children[2].$value = 'd'
+      vm.$children[2].$value = 'e'
       vm.$children[4].val = 3
+      vm.$children[5].val = 4
       _.nextTick(function () {
         expect(vm.items[0]).toBe('c')
-        expect(vm.obj[key]).toBe('d')
+        expect(vm.items[1]).toBe('d')
+        expect(vm.obj[key]).toBe('e')
         expect(vm.vals[0]).toBe(3)
+        expect(vm.vals[1]).toBe(4)
         done()
       })
     })
