Remove TODOs

stduhpf · stduhpf · commit af4f83ff7f0d · 2024-09-13T18:08:32.000+02:00
diff --git a/conditioner.hpp b/conditioner.hpp
@@ -809,10 +809,6 @@ struct SD3CLIPEmbedder : public Conditioner {
                                     &pooled_l,
                                     work_ctx);
 
-                    // clip_l.transformer.text_model.text_projection no in file, ignore
-                    // TODO: use torch.eye(embed_dim) as default clip_l.transformer.text_model.text_projection
-                    // pooled_l = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, 768);
-                    // ggml_set_f32(pooled_l, 0.f);
                 }
             }
 
@@ -862,11 +858,7 @@ struct SD3CLIPEmbedder : public Conditioner {
                                     true,
                                     &pooled_g,
                                     work_ctx);
-                    // clip_l.transformer.text_model.text_projection no in file, ignore pooled_g too
 
-                    // TODO: fix pooled_g
-                    // pooled_g = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, 1280);
-                    // ggml_set_f32(pooled_g, 0.f);
                 }
             }
 
@@ -1116,10 +1108,6 @@ struct FluxCLIPEmbedder : public Conditioner {
                                 &pooled,
                                 work_ctx);
 
-                // clip_l.transformer.text_model.text_projection no in file, ignore
-                // TODO: use torch.eye(embed_dim) as default clip_l.transformer.text_model.text_projection
-                // pooled = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, 768);
-                // ggml_set_f32(pooled, 0.f);
             }
 
             // t5

Original file line number	Diff line number	Diff line change
`@@ -809,10 +809,6 @@ struct SD3CLIPEmbedder : public Conditioner {`
`809`	`809`	`&pooled_l,`
`810`	`810`	`work_ctx);`
`811`	`811`
`812`		`- // clip_l.transformer.text_model.text_projection no in file, ignore`
`813`		`- // TODO: use torch.eye(embed_dim) as default clip_l.transformer.text_model.text_projection`
`814`		`- // pooled_l = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, 768);`
`815`		`- // ggml_set_f32(pooled_l, 0.f);`
`816`	`812`	`}`
`817`	`813`	`}`
`818`	`814`
`@@ -862,11 +858,7 @@ struct SD3CLIPEmbedder : public Conditioner {`
`862`	`858`	`true,`
`863`	`859`	`&pooled_g,`
`864`	`860`	`work_ctx);`
`865`		`- // clip_l.transformer.text_model.text_projection no in file, ignore pooled_g too`
`866`	`861`
`867`		`- // TODO: fix pooled_g`
`868`		`- // pooled_g = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, 1280);`
`869`		`- // ggml_set_f32(pooled_g, 0.f);`
`870`	`862`	`}`
`871`	`863`	`}`
`872`	`864`
`@@ -1116,10 +1108,6 @@ struct FluxCLIPEmbedder : public Conditioner {`
`1116`	`1108`	`&pooled,`
`1117`	`1109`	`work_ctx);`
`1118`	`1110`
`1119`		`- // clip_l.transformer.text_model.text_projection no in file, ignore`
`1120`		`- // TODO: use torch.eye(embed_dim) as default clip_l.transformer.text_model.text_projection`
`1121`		`- // pooled = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, 768);`
`1122`		`- // ggml_set_f32(pooled, 0.f);`
`1123`	`1111`	`}`
`1124`	`1112`
`1125`	`1113`	`// t5`