Preserve package.json structure during bootstrap mangling #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of nuking the entire package.json, just edit what we don't want installed (the sibling packages that are instead symlinked). * Adds an actual integration test for `lerna bootstrap --hoist` * Replaces bloated `cash-cp` fixture dep with basic node.js copy Credit @compulim for the initial idea, lerna#1287 Fixes lerna#1136
9 tasks
|
Hah, whoops, I forgot |
eanders-ms
pushed a commit
to microsoft/BotFramework-Emulator
that referenced
this pull request
Apr 27, 2018
# Changelog
* Put `devDependencies` to root, fixed `package-lock.json`
* Removed unnecessary `devDependencies`
* Please use `lerna add` from now on, don't use `npm install` or edit `package.json`
* To add `jest` as `devDependencies` to `botframework-emulator-shared` package
* At root, run `npm install jest --save-dev` followed by `lerna add jest --dev --scope=botframework-emulator-shared`
* Please commit `package-lock.json` if you have any changes
* Lerna [bug](lerna/lerna#1290) may cause unnecessary changes in `package-lock.json`, `#master` or `@3.0.0` will fix it
* Until their next drop, please verify/tweak your changes in `package-lock.json` before committing the file
* Bumped all dependencies to latest version
* We are on latest `typescript@2.7.2` 🎉
* `electron@1.8.1`
* `restify@4.3.2` (@6 now, but their plugins architecture changed)
* Scoping internal packages with `@bfemulator` for CI/CD on our NPM feed
* `/app/client` (`botframework-emulator-client`) is now `@bfemulator/client`
* `/app/shared` (`botframework-emulator-shared`) is now `@bfemulator/app-shared`
* Revisited all `.gitignore` files
* Added `npm test` scripts to all `package.json`, by default, use `jest`
* Temporarily added `react-app-rewired` to mix JSX in TypeScript React app (broken since `react-scripts-ts@>2.9.0`)
* [Tracking bug](wmonk/create-react-app-typescript#266) at `react-scripts-ts`, their [next drop](wmonk/create-react-app-typescript#242) should have it
# Notes
Added few TypeScript ignores because:
* Some typings are wrong (added `skipLibCheck`)
* Some typings are outdated (using `any` type)
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of nuking the entire package.json, just edit what we don't want installed (the sibling packages that are instead symlinked). This helps avoid incorrect
package-lock.jsonoutput due to missingpackage.jsonproperties (name and version, specifically).lerna bootstrap --hoistcash-cpfixture dep with basic node.js copyMotivation and Context
Credit @compulim for the initial idea, #1287
Fixes #1136
Types of changes
Checklist: